Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a word at the end of line might delete the EOL #967

Closed
Zzzen opened this issue Oct 22, 2016 · 4 comments
Closed

Deleting a word at the end of line might delete the EOL #967

Zzzen opened this issue Oct 22, 2016 · 4 comments
Labels

Comments

@Zzzen
Copy link
Contributor

Zzzen commented Oct 22, 2016

Please thumbs-up 👍 this issue if it personally affects you! You can do this by clicking on the emoji-face on the top right of this post. Issues with more thumbs-up will be prioritized.


What did you do?

  1. create a js file:
function () {
  if (true) {
    var x
  }
}
  1. Enter Normal mode, move cursor to x
  2. Input d a w
function () {
  if (true) {
    var }
}

What did you expect to happen?

The EOL should not be removed.

What happened instead?

The EOL is removed.

Technical details:

This bug only effects nested blocks.

  • VSCode Version: 1.6.1
  • VsCodeVim Version: 0.3.8
  • OS: win10
@rebornix
Copy link
Member

This bug comes again, I debt we didn't add test cases for it last time when we fixed it.

@johnfn
Copy link
Member

johnfn commented Oct 22, 2016

This bug only effects nested blocks.

😕

@Chillee
Copy link
Member

Chillee commented Apr 24, 2017

This issue is actually the same as this issue #1350, and should have been fixed in PR #1549 .

It's not that the bug only affects nested blocks, but that the bug occurs when the word on the next line has whitespace before it.

This bug shouldn't occur in VSCodeVim 0.6.18.

@xconverge
Copy link
Member

You are right just tested on this version and previous version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants