Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handleKeys doesn't work in Ver 0.10.3 #2145

Closed
michaelHL opened this issue Nov 14, 2017 · 2 comments
Closed

handleKeys doesn't work in Ver 0.10.3 #2145

michaelHL opened this issue Nov 14, 2017 · 2 comments

Comments

@michaelHL
Copy link

michaelHL commented Nov 14, 2017

BUG REPORT

Environment:

  • VSCode Version: 1.18.0
  • VsCodeVim Version: 0.10.3
  • OS: Windows 10 (1607) x64

What happened:

<C-n> give no response after updating to v0.10.3.

What did you expect to happen:

Open a new untitled file.


I have already set "<C-n>": false in "vim.handleKeys", and my settings of VsCodeVim is as follows:

settings.json
"vim.useSystemClipboard": false,
"vim.hlsearch": true,
"vim.leader": " ",
"vim.easymotion": true,
"vim.easymotionMarkerFontFamily": "Microsoft Yahei Mono",
"vim.easymotionMarkerFontSize": "18",
"vim.easymotionMarkerHeight": 17,
"vim.easymotionMarkerWidthPerChar": 11,
"vim.easymotionMarkerBackgroundColor": "#000000",
"vim.easymotionMarkerForegroundColorOneChar": "#ffffff",
"vim.easymotionMarkerForegroundColorTwoChar": "#ffffff",
"vim.easymotionMarkerYOffset": 13,
"vim.statusBarColorControl": true,
"vim.otherModesKeyBindingsNonRecursive": [{
        "before": ["leader", "w"],
        "after": [],
        "commands": [{
            "command": "workbench.action.files.save",
            "args": []
        }]
    },
    {
        "before": ["leader", "s"],
        "after": ["leader", "leader", "s"]
    },
    {
        "before": ["leader", "p"],
        "after": [],
        "commands": [{
            "command": "workbench.action.closeEditorsInGroup",
            "args": []
        }]
    },
    {
        "before": ["leader", "q"],
        "after": [],
        "commands": [{
            "command": "workbench.action.closeActiveEditor",
            "args": []
        }]
    },
    {
        "before": ["leader", "l"],
        "after": [],
        "commands": [{
            "command": "editor.action.trimTrailingWhitespace",
            "args": []
        }]
    },
    {
        "before": ["U"],
        "after": ["<C-r>"]
    },
    {
        "before": ["="],
        "after": []
    }
],
"vim.handleKeys": {
    "<C-s>": false,
    "<C-f>": false,
    "<C-j>": false,
    "<C-c>": false,
    "<C-n>": false,
    "<C-k>": false
},
@michaelHL michaelHL changed the title <C-n> conflict with New Untitled File in Ver 0.10.3 Logan's SB Nov 14, 2017
@michaelHL michaelHL changed the title Logan's SB <C-n> conflict with New Untitled File in Ver 0.10.3 Nov 14, 2017
@michaelHL michaelHL reopened this Nov 14, 2017
@jpoon
Copy link
Member

jpoon commented Nov 14, 2017

Dammit. This is my doing in the last release: https://github.com/VSCodeVim/Vim/blame/master/src/configuration/configuration.ts#L80.

I reversed the logic. The check should be if is this.handleKeys[bracketedKey]===false then we should set useKey=false.

I'm about to head out -- won't be able to get to this until the EOD. Feel free to submit a PR in the meantime. Sorry :(

@jpoon jpoon changed the title <C-n> conflict with New Untitled File in Ver 0.10.3 handleKeys doesn't work in Ver 0.10.3 Nov 14, 2017
@michaelHL
Copy link
Author

Back to normal again! 😄
Thx a lot!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants