Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll-cursor commands (zt, zb) don't work #210

Closed
stapelberg opened this issue Apr 30, 2016 · 6 comments
Closed

scroll-cursor commands (zt, zb) don't work #210

stapelberg opened this issue Apr 30, 2016 · 6 comments
Assignees
Labels

Comments

@stapelberg
Copy link

Vim has handy commands for scrolling without moving the cursor, e.g. zt, which scrolls the screen so that the line with the current cursor is placed as the first line. E.g., I often do actions like /main(<CR>zt, so that I can see as much of the main function as possible.

Would it be possible to implement zt, zb and zz?

Thanks!

@johnfn
Copy link
Member

johnfn commented Jun 18, 2016

zz has been done. zt and zb are impossible until microsoft/vscode#2771 😞

@jpoon
Copy link
Member

jpoon commented Sep 21, 2016

On 0.2.0:

  1. zz works
  2. zt and zb don't work. We do have CommandTopScroll and CommandBottomScroll which are called but the window does not update.

cc @rebornix

@jpoon jpoon changed the title scroll-cursor commands not implemented scroll-cursor commands (zt, zb) don't work Sep 21, 2016
@rebornix
Copy link
Member

@jpoon I moved the master bits to extensions folder and tried, both zt and zb work perfectly. I don't know whether we did anything wrong with compiling, this is really weird.

@jpoon
Copy link
Member

jpoon commented Sep 23, 2016

@rebornix Hmm..yeah, I see the same thing. Works in master, doesn't work in released version. Super strange. Let's hope this gets magically resolved when we release a new version.

@rebornix
Copy link
Member

@jpoon If you generate a visx and install it manually, it works as well. Let's wait and see next version!

@johnfn
Copy link
Member

johnfn commented Oct 1, 2016

This appears to be done for me. :)

@johnfn johnfn closed this as completed Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants