statusBarColors modifies workspace settings.json

[mgood]

• Click thumbs-up 👍 on this issue if you want it!
• Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.

---

What did you do?

Enabled "vim.statusBarColorControl": true

What happened instead?

The status bar color changes as expected, but it also saves those changes to my workspace .vscode/settings.json. My team keeps this file checked into Git for shared project settings, so these changes show up in my Git status and I have to be sure not to commit them.

A warning in the docs could help other users avoid the confusion about where these changes are coming from.

A more complete fix might require new APIs in VSCode for extensions to control the color without writing them to the settings file. A direct API call would probably also be more responsive. There is a noticeable delay between changing modes and the color updating that I found slightly distracting.

Technical details:

• VSCode Version: 1.11.2
• VsCodeVim Version: 0.6.18
• OS: Mac Sierra

[xconverge]

Yea this is unavoidable right now.. I would advise to gitignore the setting file locally if it bothers you or disable the feature.

I am not sure vscode will ever expose this to the API. I will add something to the readme

[xconverge]

Updated the readme for now! Thanks for reporting

[jpoon]

Why don't you put it in your user settings? https://code.visualstudio.com/docs/getstarted/settings#_settings-file-locations

Update: Hm, I see, why does this have to be in the workspace? I think I missed the memo on that one.

[xconverge]

I am not sure, that is just where it seems to go... Seeing as how the feature is experimental, I figure I will wait it out a bit from vscode side...

[rebornix]

@xconverge I'm interested in why we have to put it in workspace? workspace settings are shared in teams so making changes to it leads to unwanted git changes, sometimes we don't want to git ignore it.

[xconverge]

I didn't mean to, I just used the same calls we use elsewhere for config. I couldn't figure out how to make it go to user

[rebornix]

@xconverge thanks for the info. I just updated the code to make sure it only affects user setting.

[xconverge]

Ah well that was easy...not super intuitive of the API but that works! Thanks

[zelphir]

#1654

This change breaks workbench.colorCustomizations if you have more settings in there. Also if you have your settings.json saved in a repo it keeps changing the file