From 8403b8172e43b676295827490b5c3e76a4810874 Mon Sep 17 00:00:00 2001 From: My <84212641+My-MC@users.noreply.github.com> Date: Sun, 14 May 2023 19:51:03 +0900 Subject: [PATCH 1/8] =?UTF-8?q?Volta=E3=81=AB=E3=82=88=E3=82=8BNode.js?= =?UTF-8?q?=E3=83=90=E3=83=BC=E3=82=B8=E3=83=A7=E3=83=B3=E7=AE=A1=E7=90=86?= =?UTF-8?q?=E3=82=92=E8=BF=BD=E8=A8=98=E3=80=82=20.node=5Fversion=E3=81=A8?= =?UTF-8?q?=E3=81=AE=E5=90=8C=E6=9C=9F=E3=82=92=E7=A2=BA=E8=AA=8D=E3=81=99?= =?UTF-8?q?=E3=82=8B=E3=83=AF=E3=83=BC=E3=82=AF=E3=83=95=E3=83=AD=E3=83=BC?= =?UTF-8?q?=E3=82=92=E8=BF=BD=E5=8A=A0=E3=80=82?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/check_version.yml | 15 +++++++++++++++ package.json | 4 ++++ 2 files changed, 19 insertions(+) create mode 100644 .github/workflows/check_version.yml diff --git a/.github/workflows/check_version.yml b/.github/workflows/check_version.yml new file mode 100644 index 0000000000..f42530d5e6 --- /dev/null +++ b/.github/workflows/check_version.yml @@ -0,0 +1,15 @@ +on: + push: + pull_request: + branches: + - "**" + workflow_dispatch: + +jobs: + check_node_version: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + + - name: Synchronize volta and .node_version + uses: My-MC/check-sync-volta-and-node-version@v0.0.2 diff --git a/package.json b/package.json index 72438e92fa..341f2ea3ef 100644 --- a/package.json +++ b/package.json @@ -8,6 +8,10 @@ "node": ">=18.13.0 <19", "npm": ">=8.19.3 <9" }, + "volta": { + "node": "18.13.0", + "npm": "8.19.3" + }, "scripts": { "serve": "cross-env VITE_IS_ELECTRON=false vite", "build": "cross-env VITE_IS_ELECTRON=false vite build", From 8e49d3b0bc4972d2713c04683d89ffafc76cd24f Mon Sep 17 00:00:00 2001 From: My <84212641+My-MC@users.noreply.github.com> Date: Sun, 14 May 2023 19:55:14 +0900 Subject: [PATCH 2/8] Fix name --- .github/workflows/check_version.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check_version.yml b/.github/workflows/check_version.yml index f42530d5e6..7e13094236 100644 --- a/.github/workflows/check_version.yml +++ b/.github/workflows/check_version.yml @@ -1,3 +1,5 @@ +name: Check version + on: push: pull_request: @@ -11,5 +13,5 @@ jobs: steps: - uses: actions/checkout@v3 - - name: Synchronize volta and .node_version + - name: Check synchronize volta and .node_version uses: My-MC/check-sync-volta-and-node-version@v0.0.2 From 8664a7bf189d78eea71a420d83757e03fc29a974 Mon Sep 17 00:00:00 2001 From: My <84212641+My-MC@users.noreply.github.com> Date: Thu, 18 May 2023 22:51:20 +0900 Subject: [PATCH 3/8] =?UTF-8?q?.node=5Fversion=E3=81=BE=E3=81=9F=E3=81=AFp?= =?UTF-8?q?ackage.json=E3=81=8C=E5=A4=89=E6=9B=B4=E3=81=95=E3=82=8C?= =?UTF-8?q?=E3=81=9F=E5=A0=B4=E5=90=88=E3=81=AE=E3=81=BF=E5=AE=9F=E8=A1=8C?= =?UTF-8?q?=E3=81=99=E3=82=8B=E3=82=88=E3=81=86=E3=81=AB=E5=A4=89=E6=9B=B4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/check_version.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/check_version.yml b/.github/workflows/check_version.yml index 7e13094236..301e3c1cb3 100644 --- a/.github/workflows/check_version.yml +++ b/.github/workflows/check_version.yml @@ -5,6 +5,9 @@ on: pull_request: branches: - "**" + paths: + - "/.node-version" + - "/package.json" workflow_dispatch: jobs: From fa0a998bb07b51a126368285df95ae59dbbfc775 Mon Sep 17 00:00:00 2001 From: My <84212641+My-MC@users.noreply.github.com> Date: Thu, 18 May 2023 22:54:49 +0900 Subject: [PATCH 4/8] =?UTF-8?q?on=20push=E3=82=92=E3=81=AA=E3=81=8F?= =?UTF-8?q?=E3=81=99?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/check_version.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/check_version.yml b/.github/workflows/check_version.yml index 301e3c1cb3..016db04867 100644 --- a/.github/workflows/check_version.yml +++ b/.github/workflows/check_version.yml @@ -1,7 +1,6 @@ name: Check version on: - push: pull_request: branches: - "**" From 3ef52bb7b80b625c9968008ba63d0388f37414bc Mon Sep 17 00:00:00 2001 From: My <84212641+My-MC@users.noreply.github.com> Date: Sun, 4 Jun 2023 19:29:18 +0900 Subject: [PATCH 5/8] Update version --- .github/workflows/check_version.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_version.yml b/.github/workflows/check_version.yml index 016db04867..fd2298010d 100644 --- a/.github/workflows/check_version.yml +++ b/.github/workflows/check_version.yml @@ -16,4 +16,4 @@ jobs: - uses: actions/checkout@v3 - name: Check synchronize volta and .node_version - uses: My-MC/check-sync-volta-and-node-version@v0.0.2 + uses: My-MC/check-sync-volta-and-node-version@v0.0.3 From f1ba48135b416de518c94f9f09d69097e91f3d94 Mon Sep 17 00:00:00 2001 From: My <84212641+My-MC@users.noreply.github.com> Date: Sun, 4 Jun 2023 19:32:12 +0900 Subject: [PATCH 6/8] =?UTF-8?q?README.md=E3=81=ABVolta=E3=81=AE=E8=A8=98?= =?UTF-8?q?=E8=BC=89=E3=82=92=E8=BF=BD=E5=8A=A0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 43da8a6e0b..ec4c97fafc 100644 --- a/README.md +++ b/README.md @@ -35,7 +35,7 @@ Issue 側で取り組み始めたことを伝えるか、最初に Draft プル Node.js をインストール後、[このリポジトリ](https://github.com/VOICEVOX/voicevox.git) を Fork して `git clone` し、次のコマンドを実行してください。 -Node.js の管理ツール ([nvs](https://github.com/jasongin/nvs)など)を利用すると、 +Node.js の管理ツール ([nvs](https://github.com/jasongin/nvs)や[Volta](https://volta.sh)など)を利用すると、 [.node-version](.node-version) を簡単にインストールすることができます。 ```bash From e9c774c34656da3ec52323b4461d99b62f033965 Mon Sep 17 00:00:00 2001 From: My <84212641+My-MC@users.noreply.github.com> Date: Tue, 6 Jun 2023 20:15:20 +0900 Subject: [PATCH 7/8] =?UTF-8?q?Volta=E3=81=AE=E8=A8=98=E8=BF=B0=E3=82=92?= =?UTF-8?q?=E5=88=86=E9=9B=A2?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index ec4c97fafc..c1ae4524b6 100644 --- a/README.md +++ b/README.md @@ -35,9 +35,11 @@ Issue 側で取り組み始めたことを伝えるか、最初に Draft プル Node.js をインストール後、[このリポジトリ](https://github.com/VOICEVOX/voicevox.git) を Fork して `git clone` し、次のコマンドを実行してください。 -Node.js の管理ツール ([nvs](https://github.com/jasongin/nvs)や[Volta](https://volta.sh)など)を利用すると、 +Node.js の管理ツール ([nvs](https://github.com/jasongin/nvs)など)を利用すると、 [.node-version](.node-version) を簡単にインストールすることができます。 +また[Volta](https://volta.sh)による自動切り替えも使うことができます。 + ```bash npm ci ``` From 01a6b7a49337e8e652e716602d60efb06d2e5c01 Mon Sep 17 00:00:00 2001 From: Hiroshiba Date: Wed, 7 Jun 2023 15:02:44 +0900 Subject: [PATCH 8/8] Update .github/workflows/check_version.yml --- .github/workflows/check_version.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/check_version.yml b/.github/workflows/check_version.yml index fd2298010d..eed6fb71a7 100644 --- a/.github/workflows/check_version.yml +++ b/.github/workflows/check_version.yml @@ -2,8 +2,6 @@ name: Check version on: pull_request: - branches: - - "**" paths: - "/.node-version" - "/package.json"