Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright symbol error #337

Closed
qarlosalberto opened this issue Aug 27, 2024 · 2 comments
Closed

Copyright symbol error #337

qarlosalberto opened this issue Aug 27, 2024 · 2 comments

Comments

@qarlosalberto
Copy link
Contributor

qarlosalberto commented Aug 27, 2024

I remember that this problem was fixed some time ago. But it has appeared again when I have updated rust_hdl in TerosHDL.

TerosTechnology/vscode-terosHDL#646

The problem is related to "Copyright © 2008 IEEE. All rights reserved." (e.g: https://github.com/VHDL-LS/rust_hdl/blob/master/vhdl_libraries/ieee2008/numeric_std.vhdl#L71C8-L71C53). Could you remove all the © symbol? Or I can do it if it's ok for you.

Thanks!

@Schottkyc137
Copy link
Contributor

IMO, the "correct" solution is to require a VHDL file to be Latin-1 encoded (at least that's what the standard requires). But I agree that this is cumbersome as most editors will open files using utf-8 by default. That being said, I'm okay with you removing the copyright symbols, just open a PR.

@Schottkyc137
Copy link
Contributor

Closed with #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants