Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trip.tripLegs to trip.legs #180

Closed
schlpbch opened this issue Feb 22, 2022 · 2 comments
Closed

trip.tripLegs to trip.legs #180

schlpbch opened this issue Feb 22, 2022 · 2 comments
Assignees
@ue71603
Milestone
v2.0

Comments

@schlpbch
Copy link

Having trip.tripLegs is redundant, please rename to trip.legs with OJP 2.0. Makes it also more complaint with transmodel.

I can provide a patch if necessary.
@ue71603 ue71603 added this to the v2.0 milestone Mar 31, 2022
@ue71603 ue71603 self-assigned this Apr 22, 2022
@ue71603
Copy link
Contributor

ue71603 commented Jul 20, 2022

@schlpbch unclear what should be changed. TripLeg -> Leg. There is no tripLegs element. And for TripLeg I think it is clearer.

@ue71603 ue71603 assigned schlpbch and unassigned ue71603 Jul 20, 2022
@ue71603 ue71603 assigned ue71603 and unassigned schlpbch Aug 3, 2022
@ue71603
Copy link
Contributor

ue71603 commented Aug 3, 2022

TripLeg --> Leg

@ue71603 ue71603 mentioned this issue Aug 11, 2022
Merged
@ue71603 ue71603 closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ue71603 ue71603

Labels
None yet
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@schlpbch @ue71603