Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about OptimisationMethod #128

Closed
ue71603 opened this issue Dec 1, 2020 · 6 comments
Closed

Question about OptimisationMethod #128

ue71603 opened this issue Dec 1, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ue71603
Copy link
Contributor

ue71603 commented Dec 1, 2020

We have trains that are dominated by other trains:

  • T1 departes later than T2
  • T1 arrives earlier than T2

This results in T2 never show up with any of the given OptimisationMethods (well leastCost would work, if we had implemented that). Both trains are direct. Our example Luzern - Bern.

So, what do you think: Do we need an additional OptimisationMethod=all, that does not optimise such TripLegs away?

@pvgrumbkow
Copy link
Contributor

Hmm, what would an OptimizationMethod "all" mean? That you get one result, which fits best to an aggregation of the single optimization gains? Or one result for each OptimizationMethods?
Actually, in your described case, our system would be able to return T2, if this is defined in the data. On the other hand, it wouldn't need an OptimizationMethod for this behaviour.
Thinking more general about the OptimizationMethod, I have the impression, that it doesn't fit to reality. In public transport the shortest geographical way is not relevant to the traveler. Actually, no criterion except the travel duration can be used alone to optimize a trip. Additionally there are several criteria which could be used in parallel.
Using our system as a role model, I could think of OptimizationMethod containing only "fastest", "earliestArrival", "latestDeparture", and "earliestArrivalAndLatestDeparture". Additionally I would introduce several "IncludeXXX" parameters like "IncludeTripsWithLessChanges", "IncludeTripsWithLessWalking", "IncludeCheaperTrips", "IncludeTripsWithLessOccupancy", "IncludeTripsWithReliefTrains".
This way clients could be more exact in what they request.

@ue71603
Copy link
Contributor Author

ue71603 commented Dec 2, 2020

We did also additional thinking. E.g. if you do multi-modal travel, then the complete private mode (car) must be included also.
We also thought about allDirectPT meaning that all public transport that connects directly to origin, (via) and destination. We have this problem also Bellinzona - Lugano (Ceneri tunnel vs moutain track).

@skinkie
Copy link
Contributor

skinkie commented Dec 3, 2020

T2 will be visible by a profile query starting before or at the departure time of T2. T2 could be suggested in a depart-now or get-me-the-hell-out-of-here optimisation.

@ue71603 ue71603 added this to the later milestone Apr 5, 2022
@ue71603
Copy link
Contributor Author

ue71603 commented Apr 22, 2022

Matthias: Scenic
Stefan: Most scenic can be done with a score. Balances needed.

Will provide concrete example.

@ue71603 ue71603 self-assigned this Apr 22, 2022
@ue71603 ue71603 added the enhancement New feature or request label Apr 22, 2022
@ue71603 ue71603 modified the milestones: later, v2.0 Apr 22, 2022
@ue71603
Copy link
Contributor Author

ue71603 commented Jul 25, 2022

GetTripParamExtension
o ojp:ProfileCategories
o ojp:WalkingProfile
included

@ue71603
Copy link
Contributor Author

ue71603 commented Aug 11, 2022

superseeded by #221
#197

@ue71603 ue71603 closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants