Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement for Godette-chan and AliciaSolid_vrm-0.51 models #90

Open
fire opened this issue Jan 12, 2024 · 6 comments
Open

Replacement for Godette-chan and AliciaSolid_vrm-0.51 models #90

fire opened this issue Jan 12, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@fire
Copy link
Member

fire commented Jan 12, 2024

Consider replacing the current VRM models, Godette-chan (Godette_vrm_v4.vrm) and AliciaSolid_vrm-0.51.vrm, with alternative models.

For greater diversity in available assets.

Background

The godot-vrm project currently includes two VRM models:

  • AliciaSolid_vrm-0.51.vrm: The official reference model for the VRM specification provided by DWANGO Co., Ltd., and available under specific permissions and license information.
  • Godette_vrm_v4.vrm: An original model created by SirRichard94 and adapted to VRM by Lyuma, licensed under Creative Commons Attribution 3.0 Unported (CC-BY).

Reasons for Replacement

Representation: Having a variety of models can help ensure that different aesthetics or character types are represented, catering to a wider audience.

Proposed Actions

  1. Community Polling: Engage with the community to gauge interest in alternative models and solicit suggestions that align with the project's values and goals.
  2. Model Evaluation: Assess potential models based on criteria such as ease of use, license clarity, representation, and technical compatibility with VRM and Godot.
  3. Implementation Plan: Once suitable candidates are identified, create a clear plan for deprecating the existing models and integrating new ones, including updating documentation and examples.
@lyuma
Copy link
Member

lyuma commented Jan 13, 2024

For greater diversity in available assets

The best way to increase the diversity in sample assets is to add new models to the samples directory, which I think is reasonable.

In the past there was an idea of using the new GDQuest Godot 4 models for this, such as Sophia.
I ran into some trouble with Sophia due to it using a nonstandard rig with multiple deform bones ("Def_") for each of the standard human joints. I don't know the reason, but unfortunately those avatars were not designed to be used with the Godot Humanoid system, so I will have to understand the intended setup and improvise.

create a clear plan for deprecating the existing models

I do not see a justification for deprecating the existing models, other than that they were created as VRM 0. That said, VRM 0 is still the dominant VRM format on the market, and it is important to continue supporting this format, so I do not think there is sufficient reason to deprecate or remove the old VRM 0 models.

@Ughuuu
Copy link

Ughuuu commented Jan 13, 2024

Godette-chat I wouldn't replace. Maybe would be cool if they were each in their own folder also.

As for new entries, idk if this would be a good place to host them, as the repo size would just grow a lot. You could make another repo, eg vrm-models, and maybe add there models. A repo like this for eg: https://github.com/madjin/vrm-samples

And then have that repo added as a sub repo of this. Also would be nice to have some sort of online viewer for the models also.

As for sources, I suggest: https://hub.vroid.com/en

I propose following models from there:

Not sure about licensing though, need to check for each of them.

@fire
Copy link
Member Author

fire commented Jan 13, 2024

Should I make a tool to make a turn table animation doing walk, run, idle animations? The goal is preview these for review.

@Ughuuu
Copy link

Ughuuu commented Jan 14, 2024

Some tool would be cool for sure. If it worked on browser, even better. Maybe you just have an upload file form and you upload the animation and then you can review it and then you can add it to some place. And then a viewer where people view and can vote on them.

@Snowdaw
Copy link

Snowdaw commented Jan 17, 2024

Hi! The following two models have vrm files and are released under public domain, which would make them ideal for testing:

Test-Chan
Test-Kun

Speaking of these models, I tried to import them, but unfortunately Godot crashes on the import. Do you have any idea why this may be?

Using Godot v4.2.1.stable.official [b09f793f5] with the current Github version of Godot-VRM I get the following ouput when running with the --verbose flag

glTF: Converting spatial: Armature
glTF: Creating mesh for: Body
glTF: Creating mesh for: Hair
glTF: Converting spatial: secondary
WARNING: Ignoring face with non-finite normal in LOD generation.
     at: generate_lods (scene/resources/importer_mesh.cpp:518)
Saving scene to: res://.godot/imported/Test-Chan.vrm-b78e6f859127bda65f20fb0b9b0d8119.scn
ERROR: Condition "p_size < 0" is true. Returning: ERR_INVALID_PARAMETER
   at: resize (./core/templates/cowdata.h:265)```

@Snowdaw
Copy link

Snowdaw commented Jan 17, 2024

Seems like lyuma encountered a similair issue with: godotengine/godot#62585
Hopefully the following PR fixes this: godotengine/godot#86730

@fire fire added the enhancement New feature or request label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants