Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Query argument comments when merged types #136

Closed
helvenk opened this issue Apr 24, 2018 · 5 comments · Fixed by #196
Closed

Missing Query argument comments when merged types #136

helvenk opened this issue Apr 24, 2018 · 5 comments · Fixed by #196
Labels
⏳waiting for release This issue or pull request is waiting to be released

Comments

@helvenk
Copy link

helvenk commented Apr 24, 2018

In my schema definitions, I have commented the query argument:

type Query {
  users(
    # filter user by name
    name: String
    
    # limit for pagination
    limit: Int
  ): [User]
}

But after calling mergeType, the merged schema is:

type Query {
  users(name: String, limit: Int): [User]
}

How could I resolve this problem?

@murielsilveira
Copy link

I could make it work with a different comment notation, try it like this:

type Query {
  users(
    "filter user by name"
    name: String
    
    "limit for pagination"
    limit: Int
  ): [User]
}

I figure this out by checking these issues:

I hope it helps.

@helvenk
Copy link
Author

helvenk commented Apr 24, 2018

Thanks for your solution, it works, though it's non-standard comments

@murielsilveira
Copy link

Nice that it works, I was not sure if it was only because of the libraries that I was using or not.

But after the previous comment, as far as I checked, this is also a new standard:

But I couldn't find anything on the docs yet.

@RichardLitt RichardLitt added the 🎙️question Further information is requested label Apr 25, 2018
@kamilkisiela
Copy link
Collaborator

Should be fixed by #196

@kamilkisiela kamilkisiela mentioned this issue Jun 25, 2019
@kamilkisiela kamilkisiela added ⏳waiting for release This issue or pull request is waiting to be released and removed 🎙️question Further information is requested labels Jun 25, 2019
@kamilkisiela
Copy link
Collaborator

It's available now under v1.6.0-beta.2. Let us know if it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏳waiting for release This issue or pull request is waiting to be released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants