fix: GC: remember to signal the GC thread to stop when destroying the table.

marete · marete · commit 46dec8d7dace · 2025-08-12T01:03:42.000+03:00
diff --git a/table.h b/table.h
@@ -51,6 +51,8 @@ namespace emulator {
 class Table : public std::enable_shared_from_this<Table> {
  public:
   ~Table() {
+    // Signal the GC thread to stop and wait for it to terminate.
+    stop_flag_ = true;
     if (gc_thread_.joinable()) {
       gc_thread_.join();
     }

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,8 @@ namespace emulator {`
`51`	`51`	`class Table : public std::enable_shared_from_this<Table> {`
`52`	`52`	`public:`
`53`	`53`	`~Table() {`
	`54`	`+ // Signal the GC thread to stop and wait for it to terminate.`
	`55`	`+ stop_flag_ = true;`
`54`	`56`	`if (gc_thread_.joinable()) {`
`55`	`57`	`gc_thread_.join();`
`56`	`58`	`}`