Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if all the attainments in excludedPartialAttainments.csv should be excluded #4731

Open
valtterikantanen opened this issue Feb 3, 2025 · 0 comments
Labels
updater Updater

Comments

@valtterikantanen
Copy link
Member

valtterikantanen commented Feb 3, 2025

excludedPartialAttainments.csv has over 170,000 attainments that are not brought to sis-db from sis-importer-db. There's at least one example when attainments in the list shouldn't have been excluded (see #4396).

In order to fix these mistakes, it needs to be figured out if there are more attainments in the CSV file that shouldn't be there. My guess is that it has a lot of attainments that shouldn't be excluded because they are part of a ModuleAttainment and not a CourseUnitAttainment. Only if there are multiple CourseUnitAttainments that are acually the same attainment, the partial attainments should be excluded. Study modules are ignored in total credit calculations etc. anyway so we definitely need the CourseUnitAttainments that are included in the study module attainment.

However, it must first be verified that the attainments that need to be excluded are not part of a ModuleAttainment so that they are not incorrectly removed from the list.

Also: over 160,000 (92%) of the attainments in the list are not in sis-importer-db?

@valtterikantanen valtterikantanen added the updater Updater label Feb 3, 2025
@github-project-automation github-project-automation bot moved this to To do in Oodikone Feb 3, 2025
@valtterikantanen valtterikantanen moved this from To do to Next in Oodikone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
updater Updater
Projects
Status: Next
Development

No branches or pull requests

1 participant