Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Class statistics] sorting fkd #4647

Open
3 tasks
tttriple opened this issue Oct 15, 2024 · 0 comments
Open
3 tasks

[Class statistics] sorting fkd #4647

tttriple opened this issue Oct 15, 2024 · 0 comments
Labels
back Backend bug Something isn't working front Frontend

Comments

@tttriple
Copy link
Collaborator

tttriple commented Oct 15, 2024

Image
Currently when using tiny arrows, sorting doesnt happen. plz fix. ty.

This only happens with some (large) degree programmes and when all year classes are combined. For example here sorting works but here it doesn't.

The probable cause is that students might have multiple study rights in the same programme, which causes them to appear in the table many times (check e.g. student number ****9637). This leads to rows having same keys which means React cannot correctly identify which row is which.

To fix this, we should make sure that each student only has one entry in the backend response. But which study right should we choose if there are many?

  • Add Study right status column to Students table
  • Fix the row (i.e. wrong study right start date, study track etc.)
  • (groom) Add 'Cancelled' and 'Not cancelled' options to Study right status filter
@tttriple tttriple converted this from a draft issue Oct 15, 2024
@tttriple tttriple moved this from Priority to Next in Oodikone Oct 15, 2024
@rikurauhala rikurauhala added bug Something isn't working front Frontend back Backend labels Oct 17, 2024
@valtterikantanen valtterikantanen moved this from Next to Priority in Oodikone Feb 3, 2025
@rikurauhala rikurauhala changed the title sorting fkd [Class statistics] sorting fkd Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back Backend bug Something isn't working front Frontend
Projects
Status: Priority
Development

No branches or pull requests

4 participants