-
Notifications
You must be signed in to change notification settings - Fork 464
fix: ChangeOwnership sending own clientId and added NetworkSceneHandle struct #3647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ChangeOwnership sending own clientId and added NetworkSceneHandle struct #3647
Conversation
…ere are no valid receivers
| { | ||
| "name": "Unity", | ||
| "expression": "6000.4.0a3", | ||
| "define": "SCENE_MANAGEMENT_SCENE_HANDLE_NO_INT_CONVERSION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why 6000.4? Similar question to define above, why 6000.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entities broke us 🥲 in 6.3 they introduced a struct instead of an int for the scene handle. and then in 6.4 they removed the implicit conversions between the struct and the int.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job narrowing down the core issue with the more recent SceneHandle updates in v6.3 with a nice wrapper class, NetworkSceneHandle, to provide a smooth experience for users!
🥇
In the name of "getting the PR queue uncongested", the changelog entry for this can be found in #3707 to avoid running through CI just for the entry update.
Purpose of this PR
ClientIdslistNetworkSceneHandlestruct to wraps theSceneManagement.Scene.handlerepresentation.intto aSceneHandlestruct.intand theSceneHandleNetworkSceneHandlestruct allows us to hide this change from the rest of the codebase. It may also enable us to refactor our scene management as it gives us a more powerful representation of a scene.Jira ticket
MTTB-1570
MTTB-1646
Changelog
NetworkSceneHandlestruct that wraps theSceneManagement.Scene.handlerepresentation. This allows us to work smoothly with the latest functionality of scene management in the UnityEngineDocumentation
Testing & QA (How your changes can be verified during release Playtest)
We need to playtest with the SceneLoading scene to ensure that's still all working as expected.
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
This test is specific to 2.x so no backport required.