Skip to content

chore: Improve performance of NetworkList set operation #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 7, 2025
Merged

chore: Improve performance of NetworkList set operation #3587

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d80039
perf(networked-vars): Skip NetworkList set operation when value uncha…
harayuu9 Aug 6, 2025
d2ed595
docs: Add CHANGELOG entry for NetworkList optimization (#????)
harayuu9 Aug 6, 2025
ee1d602
Update CHANGELOG
EmandM Aug 6, 2025
7b8e5e1
Update code comment to match context
EmandM Aug 7, 2025
610b3d9
Merge branch 'develop-2.0.0' of https://github.com/Unity-Technologies…
EmandM Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions com.unity.netcode.gameobjects/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ Additional documentation and release notes are available at [Multiplayer Documen

### Changed

- Optimized `NetworkList<T>` indexer setter to skip operations when the new value equals the existing value, improving performance by avoiding unnecessary list events and network synchronization. (#3587)


## [2.5.0] - 2025-08-01

Expand Down
7 changes: 7 additions & 0 deletions com.unity.netcode.gameobjects/Runtime/NetworkVariable/Collections/NetworkList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,13 @@ public T this[int index]
}

var previousValue = m_List[index];

// Compare the Value being applied to the current value
Copy link

@NikiWalker NikiWalker Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Comment why, not what. E.g. The CHANGELOG comment above would be good as a comment here instead, for example

Copy link
Contributor

@harayuu9 harayuu9 Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As context, this was copied from the NetworkVariable implementation. I agree the comment is somewhat self-evident and likely unnecessary.

com.unity.netcode.gameobjects/com.unity.netcode.gameobjects/Runtime/NetworkVariable/NetworkVariable.cs

Lines 156 to 158 in ce3b6d9

// Compare the Value being applied to the current value
if (!NetworkVariableSerialization<T>.AreEqual(ref m_InternalValue, ref value))

if (NetworkVariableSerialization<T>.AreEqual(ref previousValue, ref value))
{
return;
}

m_List[index] = value;

var listEvent = new NetworkListEvent<T>()
Expand Down