Skip to content

Conversation

@NoelStephensUnity
Copy link
Collaborator

This is a backport of #3108.

This PR resolves the issue of exceeding the legacy parameter limitations defined within NetworkAnimator. Now, NetworkAnimator calculates how much space it needs to allocate to handle parameter serialization based on the Animator's defined parameters.

Changelog

  • Fixed: Issue where NetworkAnimator would statically allocate write buffer space for Animator parameters that could cause a write error if the number of parameters exceeded the space allocated.

Testing and Documentation

  • No tests were added.
  • No documentation changes or additions were necessary.

Pre-calculate the required parameter write size needed as opposed to using the legacy constant value.
adding changelog entry
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner November 14, 2024 23:58
Adding PR number to changelog entry
@NoelStephensUnity NoelStephensUnity merged commit 773d5f3 into develop Nov 18, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networkanimator-parameter-writebuffer-limit-backport branch November 18, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants