Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

Conversation

@johann-r-unity
Copy link
Contributor

@johann-r-unity johann-r-unity commented Apr 29, 2025

Select the type of change:

  • Small Changes - Typos, formatting, slight revisions
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site and Docusaurus

Purpose of the Pull Request:
The OptanonWrapper() function is defined twice,
once in the head (https://github.com/Unity-Technologies/com.unity.multiplayer.docs/blob/main/config/scripts.config.js)
and
once in the footer https://github.com/Unity-Technologies/com.unity.multiplayer.docs/blob/bed5b1f3995322407a0d9986bebef8c93986a9e7/src/theme/Footer/index.js
This redefinition of the function causes an issue in our data ingestion pipelines that prevents the page viewed from being accessible in the analytics.
This PR removes this second occurrence which should it turn solve this issue.

Extra context
Initial problem discussion ; https://unity.slack.com/archives/C06PNK5M0MT/p1734715219397079
Resolution discussion ; https://unity.slack.com/archives/C036K4KH963/p1745875133962669

@jabbacakes
Copy link
Collaborator

I am not remotely qualified to approve this PR, so don't wait on my review. Happy for it to merge once someone qualified has looked at it 🙏

@anilopez
Copy link

Looks good to me.
Thanks

@jabbacakes jabbacakes merged commit 600d215 into develop Apr 30, 2025
2 checks passed
@jabbacakes jabbacakes deleted the fix/ensure-data-can-be-ingested branch April 30, 2025 14:45
@johann-r-unity johann-r-unity mentioned this pull request Apr 30, 2025
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants