Add the PerforceBinaries to the repo

SRombautsU · SRombautsU · commit 351abfbe45c6 · 2025-07-25T15:54:24.000+02:00
Remove Mercurial steps to download the PerforceBinaries hg clone --config extensions.largefiles= http://hg-mirror-slo.hq.unity3d.com/unity-extra/perforce PerforceBinaries Submit a copy of the p4 & p4d binaries downloaded alongside the static libraries from https://filehost.perforce.com/perforce/r19.1 This is the correct way to manage dependencies (especially if we want to have branches using different versions) allowing to update it more easily to match the version of the p4api It will allow us to update to any Bokken image that wouldn't have Mercurial "hg" installed
diff --git a/.gitattributes b/.gitattributes
@@ -1,2 +1,3 @@
 *.lib filter=lfs diff=lfs merge=lfs -text
 *.a filter=lfs diff=lfs merge=lfs -text
+PerforceBinaries/**/p4* filter=lfs diff=lfs merge=lfs -text
diff --git a/.gitignore b/.gitignore
@@ -1,64 +1,39 @@
-# Specific
-Build/
-PerforceBinaries/
-Library/
-*.BASE.*.cpp
-*.LOCAL.*.cpp
-*.BACKUP.*.cpp
-*.REMOTE.*.cpp
-*.orig
-Test/tmp/*
-PerforcePlugin
-
-# Compiled Object files
-*.slo
-*.lo
-*.o
-*.obj
-
-# Precompiled Headers
-*.gch
-*.pch
-*.ipch
-
-# Compiled Dynamic libraries
-*.so
-*.dylib
-*.dll
-
-# Fortran module files
-*.mod
-
-# Executables
-*.exe
-*.out
-*.app
-
-# Output folders
-[Dd]ebug/
-[Rr]elease/
-[Bb]in/
-[Oo]bj/
-
-# Visual Studio 2010 local files
-*.vcxproj.user
-*.opensdf
-*.sdf
-*.suo
-
-# Visual Studio local files
-.vs/
-
-# Test Ouput
-TestResults/
-
-# Sublime files
-*.sublime-project
-*.sublime-workspace
-server.pid
-
-# VI files
-*.swp
-
-# JetBrains IDEs files
-.idea/
+# Specific
+Build/
+Library/
+*.BASE.*.cpp
+*.LOCAL.*.cpp
+*.BACKUP.*.cpp
+*.REMOTE.*.cpp
+*.orig
+Test/tmp/*
+PerforcePlugin
+
+# Output folders
+[Dd]ebug/
+[Rr]elease/
+[Bb]in/
+[Oo]bj/
+
+# Visual Studio 2010 local files
+*.vcxproj.user
+*.opensdf
+*.sdf
+*.suo
+
+# Visual Studio local files
+.vs/
+
+# Test Ouput
+TestResults/
+
+# Sublime files
+*.sublime-project
+*.sublime-workspace
+server.pid
+
+# VI files
+*.swp
+
+# JetBrains IDEs files
+.idea/
diff --git a/.yamato/linux-build.yml b/.yamato/linux-build.yml
@@ -7,8 +7,8 @@ agent:
 commands:
   # Build PerforcePlugin and TestServer
   - perl build.pl
-  # Run the tests (requires Perforce P4 CLI)
-  - hg clone --config extensions.largefiles= http://hg-mirror-slo.hq.unity3d.com/unity-extra/perforce PerforceBinaries
+
+  # Run Perforce integration tests with the TestServer
   - perl build.pl -test
 
 artifacts:
diff --git a/.yamato/osx-build.yml b/.yamato/osx-build.yml
@@ -7,8 +7,8 @@ agent:
 commands:
   # Build PerforcePlugin and TestServer
   - perl build.pl
-  # Run the tests (requires Perforce P4 CLI)
-  - hg clone --config extensions.largefiles= http://hg-mirror-slo.hq.unity3d.com/unity-extra/perforce PerforceBinaries
+
+  # Run Perforce integration tests with the TestServer
   - perl build.pl -test
 
 artifacts:
diff --git a/.yamato/windows-build.yml b/.yamato/windows-build.yml
@@ -7,8 +7,8 @@ agent:
 commands:
   # Build PerforcePlugin and TestServer
   - perl build.pl
-  # Run the tests (requires Perforce P4 CLI)
-  - hg clone --config extensions.largefiles= http://hg-mirror-slo.hq.unity3d.com/unity-extra/perforce PerforceBinaries
+
+  # Run Perforce integration tests with the TestServer
   - perl build.pl -test
 
 artifacts:
diff --git a/P4Plugin/Source/p4api/README.md b/P4Plugin/Source/p4api/README.md
@@ -2,6 +2,8 @@ Document the links from where the P4 C++ API (include files and static libraries
 
 https://filehost.perforce.com/perforce/r19.1/ p4api-2019.1.2135798
 
+Notes: see also download_perforce_binaries.ps1
+
 # linux64
 - https://filehost.perforce.com/perforce/r19.1/bin.linux26x86_64/p4api-glibc2.3-openssl1.0.2.tgz
 
diff --git a/PerforceBinaries/OSX/p4 b/PerforceBinaries/OSX/p4
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:4bbc8fd6101d27de99355302c91b271394e93ad4cfe7edf7cb7cce415c3b4322
+size 8846592
diff --git a/PerforceBinaries/OSX/p4d b/PerforceBinaries/OSX/p4d
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:1b569ef08b506e2ade9032ba68852106bb94ad6c42bd8766e2cfda0bc1a3b760
+size 14729616
diff --git a/PerforceBinaries/Win_x64/p4.exe b/PerforceBinaries/Win_x64/p4.exe
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:2f741dc72498d8286860af4f52d2bddd705fd30b6cab9443cb2559547db0e5f3
+size 5037320
diff --git a/PerforceBinaries/Win_x64/p4d.exe b/PerforceBinaries/Win_x64/p4d.exe
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:bdad2d08ebb1ed51e86f6e2468c39110880cd1ca0e67290e211d77cdc185163b
+size 8755968
diff --git a/PerforceBinaries/linux64/p4 b/PerforceBinaries/linux64/p4
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:a1a1c526b3ace83e8c3fc05e45122b5f9dffa9236e0d7572da420711522202de
+size 7976688
diff --git a/PerforceBinaries/linux64/p4d b/PerforceBinaries/linux64/p4d
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:e579458b40b1e66221e8ea5077f9b87d9328eaebec8e68b4561bfbe2824f258e
+size 14175320
diff --git a/README.md b/README.md
@@ -36,7 +36,7 @@ You need Unity 4.2+ to use the integrated version control plugins.
 To build:
 
 ```bash
-perl ./build.pl  
+perl ./build.pl
 ```
 
 To test:
@@ -45,13 +45,6 @@ To test:
 perl ./build.pl -test
 ```
 
-You need to clone `PerforceBinaries` from mercurial to get the binaries you will run the tests on. You can execute this command from NativeVersionControlPlugins root:
-```bash
-hg clone --config extensions.largefiles= http://hg-mirror-slo.hq.unity3d.com/unity-extra/perforce PerforceBinaries
-```
-
-Steps for setting up Mercurial can be found here: [Setting Up Mercurial](https://confluence.unity3d.com/display/DEV/Setting+Up+Mercurial)
-
 ### Perforce
 
 The Perforce plugin source code is located under `P4Plugin/Source`. It references the Perforce APIs,
@@ -60,6 +53,14 @@ located under `P4Plugin/Source/p4api`.
 We are targeting the 19.1 release of Perforce API includes and libraries, that were downloaded from
 the [Perforce downloads page](http://filehost.perforce.com/perforce/r19.1/).
 
+The `PerforceBinaries` where downloaded the same locations to run the integrations tests on.
+
+```bash
+mkdir -p 'PerforceBinaries\Win_x64'
+curl -ssL -o 'PerforceBinaries\Win_x64\p4.exe' 'https://filehost.perforce.com/perforce/r21.2/bin.ntx64/p4.exe'
+curl -ssL -o 'PerforceBinaries\Win_x64\p4d.exe' 'https://filehost.perforce.com/perforce/r21.2/bin.ntx64/p4d.exe'
+```
+
 #### Windows
 
 Windows static libraries are located under `P4Plugin/Source/p4api/lib/win32` and `win32debug`.
diff --git a/download_perforce_binaries.ps1 b/download_perforce_binaries.ps1
@@ -0,0 +1,10 @@
+Set-PSDebug -Trace 1
+
+curl -fssL -o 'PerforceBinaries/linux64/p4'      'https://filehost.perforce.com/perforce/r19.1/bin.linux26x86_64/p4'
+curl -fssL -o 'PerforceBinaries/linux64/p4d'     'https://filehost.perforce.com/perforce/r19.1/bin.linux26x86_64/p4d'
+curl -fssL -o 'PerforceBinaries/OSX/p4'          'https://filehost.perforce.com/perforce/r19.1/bin.macosx1010x86_64//p4'
+curl -fssL -o 'PerforceBinaries/OSX/p4d'         'https://filehost.perforce.com/perforce/r19.1/bin.macosx1010x86_64//p4d'
+curl -fssL -o 'PerforceBinaries\Win_x64\p4.exe'  'https://filehost.perforce.com/perforce/r19.1/bin.ntx64/p4.exe'
+curl -fssL -o 'PerforceBinaries\Win_x64\p4d.exe' 'https://filehost.perforce.com/perforce/r19.1/bin.ntx64/p4d.exe'
+
+Set-PSDebug -Trace 0

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`	`1`	`*.lib filter=lfs diff=lfs merge=lfs -text`
`2`	`2`	`*.a filter=lfs diff=lfs merge=lfs -text`
	`3`	`+PerforceBinaries/*/p4 filter=lfs diff=lfs merge=lfs -text`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+version https://git-lfs.github.com/spec/v1`
	`2`	`+oid sha256:4bbc8fd6101d27de99355302c91b271394e93ad4cfe7edf7cb7cce415c3b4322`
	`3`	`+size 8846592`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+version https://git-lfs.github.com/spec/v1`
	`2`	`+oid sha256:1b569ef08b506e2ade9032ba68852106bb94ad6c42bd8766e2cfda0bc1a3b760`
	`3`	`+size 14729616`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+version https://git-lfs.github.com/spec/v1`
	`2`	`+oid sha256:2f741dc72498d8286860af4f52d2bddd705fd30b6cab9443cb2559547db0e5f3`
	`3`	`+size 5037320`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+version https://git-lfs.github.com/spec/v1`
	`2`	`+oid sha256:bdad2d08ebb1ed51e86f6e2468c39110880cd1ca0e67290e211d77cdc185163b`
	`3`	`+size 8755968`