Skip to content

Conversation

@sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Jun 15, 2020

Purpose of this PR


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

JulienIgnace-Unity and others added 8 commits June 15, 2020 13:52
* start of volume docs (need switching branch)

* moar docs

* Reviewed exposure override

* Reviewed render pipeline debug window doc and changed some formatting

* Changed html links to md

* Update HDRP-Camera.md

* Removed rogue space

* Small changes to the exposure page

Co-authored-by: Lewis Jordan <[email protected]>
…896)

* Fix depth offset and transparent motion vector for unlit transparent

* cleanup and fix the shadow pre/post alpha clip
…lCameraData (1254383). (#846)

Co-authored-by: sebastienlagarde <[email protected]>
* Split GenerateHLSL code from PhysicallyBasedSkyRenderer in a separate file to fix Generator Includes tool

* Update ShaderVariablesPhysicallyBasedSky.cs.hlsl
* removed warnings related to ray binning in XR

* fix RenderRayTracedReflections with XR

* add errors if Path Tracing is used with XR single-pass

* add missing shader macros

* add entry to changelog

Co-authored-by: sebastienlagarde <[email protected]>
* Cleanup the HD fields

* Fix distortion appearing two times in the UI
* Split GenerateHLSL code from PhysicallyBasedSkyRenderer in a separate file to fix Generator Includes tool

* Update ShaderVariablesPhysicallyBasedSky.cs.hlsl

* Fix constant buffer layout for physically based sky
    - Update Vector3 to Vector4 to reflect actual padding/layout for non-DX
      platforms (both are 16 bytes in the shader space, but 12 bytes in C#)
    - Updates to shader code to reference only the float3 data being set up

* Update references screenshots

Co-authored-by: Sebastien Lagarde <[email protected]>
@sebastienlagarde sebastienlagarde merged commit a7a4b36 into master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants