Skip to content

Conversation

@cdxntchou
Copy link

@cdxntchou cdxntchou commented Nov 9, 2021

Purpose of this PR

Fixing the error: "The PickingMode enum does not contain the value Hidden. Value must be in range [Position | Ignore]." when you open a ShaderGraph editor. This is causing lots of tests to fail as well, as the error is picked up by tests that open shadergraph editors.

Seems like UIElements no longer silently ignores bad pickingmode settings, and will now complain.


Testing status

Tested opening shadergraph locally (PC D3D11 editor) -- no longer generates error.
Ran ShaderGraph edit mode and play mode tests (PC D3D11 editor) -- all pass.

Yamato:

PR ShaderGraph:
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/sg%252Ffix%252Fpicking-error-spew/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk/9860017/job/pipeline

Formatting failure appears to be from a previous PR in master (#6255)


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

github-actions bot commented Nov 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@Nightmask3 Nightmask3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@cdxntchou cdxntchou marked this pull request as ready for review November 9, 2021 22:38
@cdxntchou cdxntchou requested a review from a team as a code owner November 9, 2021 22:38
@marctem marctem merged commit e2accb2 into master Nov 9, 2021
@marctem marctem deleted the sg/fix/picking-error-spew branch November 9, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants