Skip to content

[HDRP][Path Tracing] Exposed 3 methods related to path tracing and accumulation. #6197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2021
Merged

[HDRP][Path Tracing] Exposed 3 methods related to path tracing and accumulation. #6197

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
409eea7
Made a few methods related to path tracing and accumulation public.
eturquin Nov 3, 2021
7a208cb
Updated changelog.
eturquin Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...y.render-pipelines.high-definition/Runtime/RenderPipeline/Accumulation/SubFrameManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ internal void PrepareNewSubFrame()
foreach (int camID in m_CameraCache.Keys.ToList())
maxIteration = Math.Max(maxIteration, GetCameraData(camID).currentIteration);

if (maxIteration == m_AccumulationSamples)
if (maxIteration >= m_AccumulationSamples)
{
Reset();
}
Expand Down Expand Up @@ -264,6 +264,18 @@ public void PrepareNewSubFrame()
m_SubFrameManager.PrepareNewSubFrame();
}

/// <summary>
/// Checks if the multi-frame accumulation is completed for a given camera.
/// </summary>
/// <param name="hdCamera">Camera for which the accumulation status is checked.</param>
/// <returns><c>true</c> if the accumulation is completed, <c>false</c> otherwise.</returns>
public bool IsFrameCompleted(HDCamera hdCamera)
{
int camID = hdCamera.camera.GetInstanceID();
CameraData camData = m_SubFrameManager.GetCameraData(camID);
return camData.currentIteration >= m_SubFrameManager.subFrameCount;
}

class RenderAccumulationPassData
{
public ComputeShader accumulationCS;
Expand Down
16 changes: 15 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/PathTracing/PathTracing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,26 @@ void ReleasePathTracing()
#endif // UNITY_EDITOR
}

internal void ResetPathTracing()
/// <summary>
/// Resets path tracing accumulation for all cameras.
/// </summary>
public void ResetPathTracing()
{
m_RenderSky = true;
m_SubFrameManager.Reset();
}

/// <summary>
/// Resets path tracing accumulation for a specific camera.
/// </summary>
/// <param name="hdCamera">Camera for which the accumulation is reset.</param>
public void ResetPathTracing(HDCamera hdCamera)
{
int camID = hdCamera.camera.GetInstanceID();
CameraData camData = m_SubFrameManager.GetCameraData(camID);
ResetPathTracing(camID, camData);
}

internal CameraData ResetPathTracing(int camID, CameraData camData)
{
m_RenderSky = true;
Expand Down