Skip to content

Update HDR in-code docs #6191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Update HDR in-code docs #6191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/PostProcessing/Components/Tonemapping.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ public enum FallbackHDRTonemap
ACES
}

/// <summary>
/// A <see cref="VolumeParameter"/> that holds a <see cref="NeutralRangeReductionMode"/> value.
/// </summary>
[Serializable]
public sealed class NeutralRangeReductionModeParameter : VolumeParameter<NeutralRangeReductionMode>
{
Expand All @@ -101,6 +104,9 @@ public sealed class NeutralRangeReductionModeParameter : VolumeParameter<Neutral
public NeutralRangeReductionModeParameter(NeutralRangeReductionMode value, bool overrideState = false) : base(value, overrideState) { }
}

/// <summary>
/// A <see cref="VolumeParameter"/> that holds a <see cref="HDRACESPreset"/> value.
/// </summary>
[Serializable]
public sealed class HDRACESPresetParameter : VolumeParameter<HDRACESPreset>
{
Expand All @@ -112,6 +118,9 @@ public sealed class HDRACESPresetParameter : VolumeParameter<HDRACESPreset>
public HDRACESPresetParameter(HDRACESPreset value, bool overrideState = false) : base(value, overrideState) { }
}

/// <summary>
/// A <see cref="VolumeParameter"/> that holds a <see cref="FallbackHDRTonemap"/> value.
/// </summary>
[Serializable]
public sealed class FallbackHDRTonemapParameter : VolumeParameter<FallbackHDRTonemap>
{
Expand Down
2 changes: 1 addition & 1 deletion ...y.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.PostProcess.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4097,7 +4097,7 @@ static Vector3 GetColorBalanceCoeffs(float temperature, float tint)
return new Vector3(w1.x / w2.x, w1.y / w2.y, w1.z / w2.z);
}

public static void GetHDROutputParameters(Tonemapping tonemappingComponent, out Vector4 hdrOutputParameters1, out Vector4 hdrOutputParameters2)
static void GetHDROutputParameters(Tonemapping tonemappingComponent, out Vector4 hdrOutputParameters1, out Vector4 hdrOutputParameters2)
{
var minNits = HDROutputSettings.main.minToneMapLuminance;
var maxNits = HDROutputSettings.main.maxToneMapLuminance;
Expand Down