[VFX] Fix usage on texture internally in SG #5793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced by #5416 We should also include texture internally declared in SG -_-'
It shouldn't modify the image reference
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. VFX Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
julienf-unity
approved these changes
Sep 29, 2021
VitaVFX
approved these changes
Oct 4, 2021
VitaVFX
left a comment
VitaVFX
left a comment
There was a problem hiding this comment.
Looking great, thank you!
Tested:
- Gather Texture 2D/3D,Texture 2D Array, Load/Sample Texture 2D Array, Sample/Load Texture 2D/3D, cubemap
- Ran FTP
- Checked URP and HDRP
PaulDemeulenaere
deleted the
vfx/fix/1367167-regression-of-texture-redefinition
branch
PaulDemeulenaere
added a commit
that referenced
this pull request
Oct 5, 2021
* Fix case https://fogbugz.unity3d.com/f/cases/1367167/ Regression introduced by #5416 We should also include texture internally declared in SG -_-' * *Improve coverage using a texture only internally in shaderGraph It shouldn't modify the image reference * *Update changelog.md (cherry picked from commit 9c71fab) # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
PaulDemeulenaere
added a commit
that referenced
this pull request
Oct 22, 2021
* Fix case https://fogbugz.unity3d.com/f/cases/1367167/ Regression introduced by #5416 We should also include texture internally declared in SG -_-' * *Improve coverage using a texture only internally in shaderGraph It shouldn't modify the image reference * *Update changelog.md (cherry picked from commit 9c71fab) # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
Contributor
Author
|
Already backported in #5914 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix regression introduced at #5416
https://fogbugz.unity3d.com/f/cases/1367167/
We shouldn't only list texture declared as input slot but also internal texture listed in
textureInfosIt only concerns the new SG integration.
Testing status
In URP We use an internal texture declaration (which ends in textureInfos)
In HDRP We use an exposed texture (which ends in InputSlot).
Comments to reviewers
N/A