-
Notifications
You must be signed in to change notification settings - Fork 862
[10.x.x][VFX] Importer and compilation various fixes #5372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.x.x][VFX] Importer and compilation various fixes #5372
Conversation
|
It appears that you made a non-draft PR! |
PaulDemeulenaere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same change than #5371 (review) 🟢
VladNeykov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on slack, one of the cases (1355820) still reproduces, and the FTP project has a change of behavior due to the World to Local fixes.
Otherwise, no issues found. @julienf-unity please let me know how you'd like to proceed (if the change of behavior is expected and the order of transformations should be fixed here or removed from the changelog and addressed later)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked this change 86083d4 🟢
VladNeykov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, no outstanding issues pertaining to this PR (test doc). Thanks for the fix!
Purpose of this PR
Various fixes:
This is a backport of #5371
Testing status
Tested locally
Comments to reviewers
This PR is meant to be backported to partner branch.
It is high priority