Skip to content

Fix double sided option moving when toggling it in the material UI #4725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Fix double sided option moving when toggling it in the material UI #4725

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dbc129
Fix double sided option moving when toggling it in the material UI (c…
May 31, 2021
f658d9f
Updated changelog
May 31, 2021
a638677
Merge branch 'hd/bugfix' into hd/fix/double-sided-material-ui
sebastienlagarde Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a divide-by-zero warning for anisotropic shaders (Fabric, Lit).
- Fixed VfX lit particle AOV output color space.
- Fixed path traced transparent unlit material (case 1335500).
- Fixed the double sided option moving when toggling it in the material UI (case 1328877).

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
6 changes: 6 additions & 0 deletions com.unity.render-pipelines.high-definition/Editor/Material/UIBlocks/SurfaceOptionUIBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,12 @@ protected void DrawSurfaceGUI()
EditorGUI.indentLevel++;
if (doubleSidedEnable != null && doubleSidedEnable.floatValue == 0 && opaqueCullMode != null)
materialEditor.ShaderProperty(opaqueCullMode, Styles.opaqueCullModeText);
else
{
EditorGUI.BeginDisabledGroup(true);
EditorGUILayout.Popup(Styles.opaqueCullModeText, 0, new string[] { "Off" });
EditorGUI.EndDisabledGroup();
}
EditorGUI.indentLevel--;
if (HDRenderQueue.k_RenderQueue_AfterPostProcessOpaque.Contains(renderQueue))
{
Expand Down