Skip to content

Fix Jittered Project Matrix Infinite Far Clip Plane #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2021
Merged

Fix Jittered Project Matrix Infinite Far Clip Plane #4638

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
150bab9
Reconstruct jittered projection matrix far plane (for Infinite )
johnpars May 25, 2021
1556e17
Changelog
johnpars May 25, 2021
dc66260
Merge branch 'hd/bugfix' into HDRP/fix-1336317
sebastienlagarde May 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed HDRP's ShaderGraphVersion migration management which was broken.
- Fixed missing API documentation for LTC area light code.
- Fixed diffusion profile breaking after upgrading HDRP (case 1337892).
- Fixed an issue with TAA causing objects not to render at extremely high far flip plane values.

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
5 changes: 5 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1673,6 +1673,11 @@ Matrix4x4 GetJitteredProjectionMatrix(Matrix4x4 origProj)
planes.top += planeJitter.y;
planes.bottom += planeJitter.y;

// Reconstruct the far plane for the jittered matrix.
// For extremely high far clip planes, the decomposed projection zFar evaluates to infinity.
if (float.IsInfinity(planes.zFar))
planes.zFar = frustum.planes[5].distance;

proj = Matrix4x4.Frustum(planes);
}

Expand Down