Skip to content

[Fogbugz 1324000] Fixing unlit emissive reflections #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2021
Merged

[Fogbugz 1324000] Fixing unlit emissive reflections #4340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0414ba7
Fix ray tracing unlit emissive exposure.
kecho Apr 27, 2021
a216e72
Automated tests coverage
remi-chapelain Apr 28, 2021
f98cb59
update scenes
remi-chapelain Apr 28, 2021
dedc26a
Merge branch 'hd/bugfix' into HDRP/FixRaytracingUnlitEmissiveExposure
sebastienlagarde Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed issue with RAS build fail when LOD was missing a renderer
- Fixed an issue where sometime a docked lookdev could be rendered at zero size and break.
- Fixed an issue where runtime debug window UI would leak game objects.
- Fixed ray traced reflections that were too dark for unlit materials. Reflections are now more consistent with the material emissiveness.

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
5 changes: 4 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Material/Unlit/UnlitRaytracing.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ void FitToStandardLit( SurfaceData surfaceData
ZERO_INITIALIZE(StandardBSDFData, outStandardlit);

// Output is not to be lit
outStandardlit.emissiveAndBaked = surfaceData.color * GetInverseCurrentExposureMultiplier() + builtinData.emissiveColor;
//Note: we have to multiply everything with the inverse exposure, since the result buffer expects everything to be 'pre exposed'.
//Is important to know too that we are applying InverseCurrentExposure twice (since this is just for reflections). Once when generating the material emissive value,
//and once more for render target storage.
outStandardlit.emissiveAndBaked = (surfaceData.color + builtinData.emissiveColor) * GetInverseCurrentExposureMultiplier();
outStandardlit.isUnlit = 1;

// Be cause this will not be lit, we need to apply atmospheric scattering right away
Expand Down