[VFX] Staging for 7.5.3 #3236
Merged
[VFX] Staging for 7.5.3 #3236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trick ExcludeFromPreset Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject. Extend the VFXInfo is valid to filter out preset. * Fix missing ExcludeFromPreset for subgraph * *Update changelog # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
* Base Commit * Updated Documentation with explicit limitations. * Fixed incorrect Merge * Add regression Test * Removed Test as It can't handle Exceptions thrown in Custom Importers * Fixed value divider Co-authored-by: Thomas ICHÉ <[email protected]>
# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
* Update Pass.template * Update CHANGELOG.md # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
* Prevent pasting context within operator/block subgraph * Fix case https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/191#discussion_r102007 Fix Approximate english log warning * Update VFXPaste log message Missing "the" # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
* Fix missing call to CreateVFXEventAttribute OnValidate is only called in editor, in runtime, we should init cache data with OnEnable * *Update changelog.md
Slightly diff which probably comes from a change in trunk
julienf-unity
approved these changes
Jan 22, 2021
Contributor
Author
|
@julienf-unity all VFX job are green, other failing are also in target branch, see 3e8aa97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Batch of backport :
Fix Preset (with exclusion) (Fixed runtime test for Yamato #177)
Fix 1276602 incorrect uchar pcache import (Hdrp/runtimetests/ps4 fix #129)
Fix Case 1223747 - NaN caused by normal bending ([9.x.x] Fixed Quality Settings changing without user interaction v2. #181)
[Subgraph] Prevent Pasting Context invalid subgraph (Update changelog for 8.1.0 [Skip CI] #191)
Fix Mouse Event Binder in player (update manifest for template for 8.1.0 + fix issue in hdrp template #175)
Also update vfx : no change in serialized data
Testing status
Comments to reviewers
We had to update test using shadow due to a slightly change, this issue was already on 7.x.x/release (see here)