Skip to content

Fix issue with shadow mask and area lights #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Fix issue with shadow mask and area lights #3019

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98ac2c9
Not checking NdotL since it's not really valid for area lights (We ha…
FrancescoC-unity Jan 7, 2021
79196b5
Changelog
FrancescoC-unity Jan 7, 2021
9241433
Merge branch 'hd/bugfix' into HDRP/fix-shadowmask-with-area-light
sebastienlagarde Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed an issue with half res ssgi upscale.
- Fixed Clearcoat on Stacklit or Lit breaks when URP is imported into the project (case 1297806)
- Fixed timing issues with accumulation motion blur
- Fixed issue with shadow mask and area lights.

### Changed
- Removed the material pass probe volumes evaluation mode.
Expand Down
3 changes: 1 addition & 2 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/LightEvaluation.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,12 +481,11 @@ SHADOW_TYPE EvaluateShadow_RectArea( LightLoopContext lightLoopContext, Position
#ifndef LIGHT_EVALUATION_NO_SHADOWS
float shadow = 1.0;
float shadowMask = 1.0;
float NdotL = dot(N, L); // Disable contact shadow and shadow mask when facing away from light (i.e transmission)

#ifdef SHADOWS_SHADOWMASK
// shadowMaskSelector.x is -1 if there is no shadow mask
// Note that we override shadow value (in case we don't have any dynamic shadow)
shadow = shadowMask = (light.shadowMaskSelector.x >= 0.0 && NdotL > 0.0) ? dot(BUILTIN_DATA_SHADOW_MASK, light.shadowMaskSelector) : 1.0;
shadow = shadowMask = (light.shadowMaskSelector.x >= 0.0) ? dot(BUILTIN_DATA_SHADOW_MASK, light.shadowMaskSelector) : 1.0;
#endif

// When screen space shadows are not supported, this value is stripped out as it is a constant.
Expand Down