Skip to content

Commit febec30

Browse files
Revert "Disable async compute for D3D12 [Hold] (#301)"
This reverts commit dc35b61.
1 parent e7a9fdb commit febec30

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

com.unity.render-pipelines.high-definition/Documentation~/Frame-Settings.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ These settings control lighting features for your rendering components. Here you
9393
### Asynchronous Compute Shaders
9494

9595
These settings control which effects, if any, can make use execute compute Shader commands in parallel.
96-
Note that these settings will have an effect only if asynchronous compute is supported by the target platform.
9796

9897
| **Property** | **Description** |
9998
| ---------------------------------- | ------------------------------------------------------------ |

com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Settings/FrameSettings.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -765,8 +765,7 @@ internal static void Sanitize(ref FrameSettings sanitizedFrameSettings, Camera c
765765
sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.Distortion] &= renderPipelineSettings.supportDistortion && !msaa && !preview;
766766
sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.LowResTransparent] &= renderPipelineSettings.lowresTransparentSettings.enabled;
767767

768-
// NOTE: We currently disable async compute on D3D12 for an issue we have with constant buffer update. TODO We need to renable it when case 1238431 is resolved
769-
bool async = sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.AsyncCompute] &= (SystemInfo.supportsAsyncCompute && SystemInfo.graphicsDeviceType != GraphicsDeviceType.Direct3D12);
768+
bool async = sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.AsyncCompute] &= SystemInfo.supportsAsyncCompute;
770769
sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.LightListAsync] &= async;
771770
sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.SSRAsync] &= (async && !rayTracingActive);
772771
sanitizedFrameSettings.bitDatas[(int)FrameSettingsField.SSAOAsync] &= (async && !rayTracingActive);

0 commit comments

Comments
 (0)