HDRP bugfix branch to master (#2350)

* Fixing exceptions in the console when putting the SSGI in low quality mode (render graph). (#2323)

* Add VT frame settings (#2286)

* Add frame setting

* changelog

* Grey setting out and make it always available.

* Reverts tuff meant for antoher branch

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Fix undo/redo compositor (#2300)

* Rename function

* Undoable "enable compositor"

* Undo/Redo Enable/Disable compositor

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Restored purge of unused resources in render graph (#2306)

* Improve punctual shadow resolution rescale algorithm (#2309)

* Improved the punctual shadow algorithm (it's less agressive now)

* Updated changelog

* Remove unused references of the HDRP asset in decal code (#2326)

* Remove perChannelMask

* changelog

* Fix diffusion profile dependency (#2327)

* Fixed a nullref when a diffusion profile was created

* Updated changelog

* Trying to fix diffusion profile asset dependency

* Fixed export as package

* Updated changelog

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Standardize naming for Transparent receive SSR (#2329)

* Renaming

* Changelog

* Fix typos

* Revert "Standardize naming for Transparent receive SSR (#2329)"

This reverts commit 58152f0.

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Improvements to the DXR Wizard (#2295)

* - Now the DXR wizard displays the name of the target asset that needs to be changed.
- The DXR wizard displays asset changes as warnings and default frame settings as infos.
- Added the status check of default camera frame settings in the DXR wizard.

* review corrections

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Expose HDRP shader tag IDs and per object config (#2292)

* Expose shader pass names API

* Updated changelog

* exposed per object data in HDUtils

* changed constants to accessors

* Moved getters to static

Co-authored-by: JulienIgnace-Unity <[email protected]>

* - Updated the documentation about shadow matte and SSShadow and RTShadows. (#2339)

* - Updated the documentation about shadow matte and SSShadow and RTShadows.

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <[email protected]>

* Fixed warnings when new input system is enabled (#2274)

* Fix nan when decal affect normals (#2319)

* Use SafeNormalize

* Update CHANGELOG.md

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Fix bleeding of a view into another caused by TAA (#2317)

* Make sure we clamp correctly when sampling in TAA

* Changelog

* More safe fix.

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Reset RT Handle size every now and then in editor if set to a big resolution and then reverted back (#2322)

* Reset every now and then

* Changelog

* Bump min to 1440

* Update CHANGELOG.md

Fixed changelog

* Avoid reset if we still need the high res

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Hdrp/standardize transparent receive ssr (#2338)

* Renaming

* Changelog

* Fix typos

* Update HDWizard.Window.cs

typo

* Update HDWizard.Window.cs

typo 2

Co-authored-by: FrancescoC-Unity <[email protected]>

* Added default volume profile asset change to the undo stack (case 1285268). (#2330)

* Added default volume profile asset change to the undo stack.

* Updated changelog.

* ...

* ...

Co-authored-by: JulienIgnace-Unity <[email protected]>

* Restored default directional light intensity constant (#2345)

* Fixed changelog

* More changelog fix

* Remove useless menu entry (#2335)

* Fixed the ray tracing shadow UI being displayed while it shouldn't (case 1286391). (#2341)

Co-authored-by: sebastienlagarde <[email protected]>

* Add fade distance for light impact on volumetrics (#2291)

* Fade

* changelog

* Don't display on directional

Co-authored-by: sebastienlagarde <[email protected]>

* Fix bit in FrameSettings

* Update sample cubemap image

* Revert "Update sample cubemap image"

This reverts commit 32ba2a8.

* revert: Improve punctual shadow resolution rescale algorithm (#2309)

* Update TestCaseFilters.asset

* Merge branch 'master' into hd/bugfix

* Update SG_DS_Flipped.mat

* update settings

* Update CHANGELOG.md

* remove test case filter in runtime test

* migrate correctly to enable virtual texturing.

* revert some change one in Hdrp/standardize transparent receive ssr #2338

* Fix breaking change in CoreEditorUtils.cs

* Revert "remove test case filter in runtime test"

This reverts commit ce8389b.

* Revert "Restored purge of unused resources in render graph (#2306)"

This reverts commit bc54701.

* Update documentation

* Revert: Fix nan when decal affect normals (#2319)

Co-authored-by: anisunity <[email protected]>
Co-authored-by: FrancescoC-unity <[email protected]>
Co-authored-by: Adrien de Tocqueville <[email protected]>
Co-authored-by: Antoine Lelievre <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>
Co-authored-by: FrancescoC-Unity <[email protected]>
Co-authored-by: Emmanuel Turquin <[email protected]>

Author: 7 people

TestProjects/HDRP_DXR_Tests/ProjectSettings/ProjectSettings.asset

@@ -3,7 +3,7 @@
 --- !u!129 &1
 PlayerSettings:
   m_ObjectHideFlags: 0
-  serializedVersion: 20
+  serializedVersion: 21
   productGUID: 504231709d29f6341950ddd13dd16f85
   AndroidProfiler: 0
   AndroidFilterTouchesWhenObscured: 0
@@ -113,8 +113,14 @@ PlayerSettings:
   switchNVNShaderPoolsGranularity: 33554432
   switchNVNDefaultPoolsGranularity: 16777216
   switchNVNOtherPoolsGranularity: 16777216
+  switchNVNMaxPublicTextureIDCount: 0
+  switchNVNMaxPublicSamplerIDCount: 0
+  stadiaPresentMode: 0
+  stadiaTargetFramerate: 0
   vulkanNumSwapchainBuffers: 3
   vulkanEnableSetSRGBWrite: 0
+  vulkanEnablePreTransform: 0
+  vulkanEnableLateAcquireNextImage: 0
   m_SupportedAspectRatios:
     4:3: 1
     5:4: 1
@@ -129,31 +135,6 @@ PlayerSettings:
   xboxOneDisableKinectGpuReservation: 0
   xboxOneEnable7thCore: 0
   vrSettings:
-    cardboard:
-      depthFormat: 0
-      enableTransitionView: 0
-    daydream:
-      depthFormat: 0
-      useSustainedPerformanceMode: 0
-      enableVideoLayer: 0
-      useProtectedVideoMemory: 0
-      minimumSupportedHeadTracking: 0
-      maximumSupportedHeadTracking: 1
-    hololens:
-      depthFormat: 1
-      depthBufferSharingEnabled: 0
-    lumin:
-      depthFormat: 0
-      frameTiming: 2
-      enableGLCache: 0
-      glCacheMaxBlobSize: 524288
-      glCacheMaxFileSize: 8388608
-    oculus:
-      sharedDepthBuffer: 1
-      dashSupport: 1
-      lowOverheadMode: 0
-      protectedContext: 0
-      v2Signing: 1
     enable360StereoCapture: 0
   isWsaHolographicRemotingEnabled: 0
   enableFrameTimingStats: 0
@@ -164,8 +145,13 @@ PlayerSettings:
   resolutionScalingMode: 0
   androidSupportedAspectRatio: 1
   androidMaxAspectRatio: 2.1
-  applicationIdentifier: {}
-  buildNumber: {}
+  applicationIdentifier:
+    Standalone: com.DefaultCompany.HDRPDXRTests
+  buildNumber:
+    Standalone: 0
+    iPhone: 0
+    tvOS: 0
+  overrideDefaultApplicationIdentifier: 0
   AndroidBundleVersionCode: 1
   AndroidMinSdkVersion: 19
   AndroidTargetSdkVersion: 0
@@ -192,22 +178,6 @@ PlayerSettings:
   uIStatusBarHidden: 1
   uIExitOnSuspend: 0
   uIStatusBarStyle: 0
-  iPhoneSplashScreen: {fileID: 0}
-  iPhoneHighResSplashScreen: {fileID: 0}
-  iPhoneTallHighResSplashScreen: {fileID: 0}
-  iPhone47inSplashScreen: {fileID: 0}
-  iPhone55inPortraitSplashScreen: {fileID: 0}
-  iPhone55inLandscapeSplashScreen: {fileID: 0}
-  iPhone58inPortraitSplashScreen: {fileID: 0}
-  iPhone58inLandscapeSplashScreen: {fileID: 0}
-  iPadPortraitSplashScreen: {fileID: 0}
-  iPadHighResPortraitSplashScreen: {fileID: 0}
-  iPadLandscapeSplashScreen: {fileID: 0}
-  iPadHighResLandscapeSplashScreen: {fileID: 0}
-  iPhone65inPortraitSplashScreen: {fileID: 0}
-  iPhone65inLandscapeSplashScreen: {fileID: 0}
-  iPhone61inPortraitSplashScreen: {fileID: 0}
-  iPhone61inLandscapeSplashScreen: {fileID: 0}
   appleTVSplashScreen: {fileID: 0}
   appleTVSplashScreen2x: {fileID: 0}
   tvOSSmallIconLayers: []
@@ -235,15 +205,16 @@ PlayerSettings:
   iOSLaunchScreeniPadFillPct: 100
   iOSLaunchScreeniPadSize: 100
   iOSLaunchScreeniPadCustomXibPath: 
-  iOSUseLaunchScreenStoryboard: 0
   iOSLaunchScreenCustomStoryboardPath: 
+  iOSLaunchScreeniPadCustomStoryboardPath: 
   iOSDeviceRequirements: []
   iOSURLSchemes: []
   iOSBackgroundModes: 0
   iOSMetalForceHardShadows: 0
   metalEditorSupport: 1
   metalAPIValidation: 1
   iOSRenderExtraFrameOnPause: 0
+  iosCopyPluginsCodeInsteadOfSymlink: 0
   appleDeveloperTeamID: 
   iOSManualSigningProvisioningProfileID: 
   tvOSManualSigningProvisioningProfileID: 
@@ -253,9 +224,17 @@ PlayerSettings:
   iOSRequireARKit: 0
   iOSAutomaticallyDetectAndAddCapabilities: 1
   appleEnableProMotion: 0
+  shaderPrecisionModel: 0
   clonedFromGUID: 7aaaa0dc1bd27d24f84a19b5893c8bae
   templatePackageId: [email protected]
   templateDefaultScene: Assets/Scenes/SampleScene.unity
+  useCustomMainManifest: 0
+  useCustomLauncherManifest: 0
+  useCustomMainGradleTemplate: 0
+  useCustomLauncherGradleManifest: 0
+  useCustomBaseGradleTemplate: 0
+  useCustomGradlePropertiesTemplate: 0
+  useCustomProguardFile: 0
   AndroidTargetArchitectures: 1
   AndroidSplashScreenScale: 0
   androidSplashScreen: {fileID: 0}
@@ -273,13 +252,16 @@ PlayerSettings:
     height: 180
     banner: {fileID: 0}
   androidGamepadSupportLevel: 0
+  AndroidMinifyWithR8: 0
+  AndroidMinifyRelease: 0
+  AndroidMinifyDebug: 0
   AndroidValidateAppBundleSize: 1
   AndroidAppBundleSizeToValidate: 100
   m_BuildTargetIcons: []
   m_BuildTargetPlatformIcons: []
   m_BuildTargetBatching:
   - m_BuildTarget: Standalone
-    m_StaticBatching: 1
+    m_StaticBatching: 0
     m_DynamicBatching: 0
   - m_BuildTarget: tvOS
     m_StaticBatching: 1
@@ -334,7 +316,7 @@ PlayerSettings:
     m_Automatic: 1
   - m_BuildTarget: AppleTVSupport
     m_APIs: 10000000
-    m_Automatic: 0
+    m_Automatic: 1
   - m_BuildTarget: WebGLSupport
     m_APIs: 0b000000
     m_Automatic: 1
@@ -368,6 +350,7 @@ PlayerSettings:
   - m_BuildTarget: Windows Store Apps
     m_EncodingQuality: 2
   m_BuildTargetGroupLightmapSettings: []
+  m_BuildTargetNormalMapEncoding: []
   playModeTestRunnerEnabled: 0
   runPlayModeTestAsEditModeTest: 0
   actionOnDotNetUnhandledException: 1
@@ -509,6 +492,7 @@ PlayerSettings:
   switchSocketInitializeEnabled: 1
   switchNetworkInterfaceManagerInitializeEnabled: 1
   switchPlayerConnectionEnabled: 1
+  switchUseNewStyleFilepaths: 0
   ps4NPAgeRating: 12
   ps4NPTitleSecret: 
   ps4NPTrophyPackPath: 
@@ -535,6 +519,7 @@ PlayerSettings:
   ps4ShareFilePath: 
   ps4ShareOverlayImagePath: 
   ps4PrivacyGuardImagePath: 
+  ps4ExtraSceSysFile: 
   ps4NPtitleDatPath: 
   ps4RemotePlayKeyAssignment: -1
   ps4RemotePlayKeyMappingDir: 
@@ -560,6 +545,7 @@ PlayerSettings:
   ps4UseResolutionFallback: 0
   ps4ReprojectionSupport: 0
   ps4UseAudio3dBackend: 0
+  ps4UseLowGarlicFragmentationMode: 1
   ps4SocialScreenEnabled: 0
   ps4ScriptOptimizationLevel: 0
   ps4Audio3dVirtualSpeakerCount: 14
@@ -576,6 +562,8 @@ PlayerSettings:
   ps4disableAutoHideSplash: 0
   ps4videoRecordingFeaturesUsed: 0
   ps4contentSearchFeaturesUsed: 0
+  ps4CompatibilityPS5: 0
+  ps4GPU800MHz: 1
   ps4attribEyeToEyeDistanceSettingVR: 0
   ps4IncludedModules:
   - libc.prx
@@ -606,17 +594,23 @@ PlayerSettings:
   webGLAnalyzeBuildSize: 0
   webGLUseEmbeddedResources: 0
   webGLCompressionFormat: 1
+  webGLWasmArithmeticExceptions: 0
   webGLLinkerTarget: 1
   webGLThreadsSupport: 0
   webGLDecompressionFallback: 0
   scriptingDefineSymbols:
     1: UNITY_HDRP_DXR_TESTS_DEFINE;ENABLE_RAYTRACING
+  additionalCompilerArguments: {}
   platformArchitecture: {}
   scriptingBackend: {}
   il2cppCompilerConfiguration: {}
   managedStrippingLevel: {}
   incrementalIl2cppBuild: {}
+  suppressCommonWarnings: 1
   allowUnsafeCode: 0
+  useDeterministicCompilation: 1
+  useReferenceAssemblies: 1
+  enableRoslynAnalyzers: 1
   additionalIl2CppArgs: 
   scriptingRuntimeVersion: 1
   gcIncremental: 0
@@ -676,10 +670,8 @@ PlayerSettings:
   XboxOnePersistentLocalStorageSize: 0
   XboxOneXTitleMemory: 8
   XboxOneOverrideIdentityName: 
-  vrEditorSettings:
-    daydream:
-      daydreamIconForeground: {fileID: 0}
-      daydreamIconBackground: {fileID: 0}
+  XboxOneOverrideIdentityPublisher: 
+  vrEditorSettings: {}
   cloudServicesEnabled:
     UNet: 1
   luminIcon:
@@ -694,12 +686,12 @@ PlayerSettings:
     m_VersionCode: 1
     m_VersionName: 
   apiCompatibilityLevel: 6
+  activeInputHandler: 0
   cloudProjectId: 
   framebufferDepthMemorylessMode: 0
+  qualitySettingsNames: []
   projectName: 
   organizationId: 
   cloudEnabled: 0
-  enableNativePlatformBackendsForNewInputSystem: 0
-  disableOldInputManagerSupport: 0
   legacyClampBlendShapeWeights: 0
   virtualTexturingSupportEnabled: 0

TestProjects/HDRP_RuntimeTests/Assets/TestCaseFilters.asset

@@ -17,25 +17,7 @@ MonoBehaviour:
     FilteredScenes:
     - {fileID: 102900000, guid: b0ec7521f32466147a09e7dadff3ae0e, type: 3}
     ColorSpace: 1
-    BuildPlatform: 5
-    GraphicsDevice: 21
-    XrSdk: 
-    StereoModes: 0
-    Reason: all black on Yamato but work locally
-  - FilteredScene: {fileID: 0}
-    FilteredScenes:
-    - {fileID: 102900000, guid: b0ec7521f32466147a09e7dadff3ae0e, type: 3}
-    ColorSpace: 1
-    BuildPlatform: 24
-    GraphicsDevice: 21
-    XrSdk: 
-    StereoModes: 0
-    Reason: all black on Yamato but work locally
-  - FilteredScene: {fileID: 0}
-    FilteredScenes:
-    - {fileID: 102900000, guid: 897c2870240f77a46a18884a0446b797, type: 3}
-    ColorSpace: 1
-    BuildPlatform: 5
+    BuildPlatform: -2
     GraphicsDevice: 21
     XrSdk: 
     StereoModes: 0
@@ -44,7 +26,7 @@ MonoBehaviour:
     FilteredScenes:
     - {fileID: 102900000, guid: 897c2870240f77a46a18884a0446b797, type: 3}
     ColorSpace: 1
-    BuildPlatform: 24
+    BuildPlatform: -2
     GraphicsDevice: 21
     XrSdk: 
     StereoModes: 0

TestProjects/HDRP_Tests/Assets/GraphicTests/Scenes/8x_ShaderGraph/8101_Opaque/SG_DS_Flipped.mat

@@ -12,7 +12,7 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: da692e001514ec24dbc4cca1949ff7e8, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
-  version: 9
+  version: 11
 --- !u!21 &2100000
 Material:
   serializedVersion: 6
@@ -127,6 +127,18 @@ Material:
         m_Texture: {fileID: 0}
         m_Scale: {x: 1, y: 1}
         m_Offset: {x: 0, y: 0}
+    - unity_Lightmaps:
+        m_Texture: {fileID: 0}
+        m_Scale: {x: 1, y: 1}
+        m_Offset: {x: 0, y: 0}
+    - unity_LightmapsInd:
+        m_Texture: {fileID: 0}
+        m_Scale: {x: 1, y: 1}
+        m_Offset: {x: 0, y: 0}
+    - unity_ShadowMasks:
+        m_Texture: {fileID: 0}
+        m_Scale: {x: 1, y: 1}
+        m_Offset: {x: 0, y: 0}
     m_Floats:
     - Vector1_52486F46: 0.5
     - Vector1_BEAFB0DB: 0.5

TestProjects/HDRP_Tests/ProjectSettings/HDRPProjectSettings.asset

@@ -13,9 +13,6 @@ MonoBehaviour:
   m_Name: 
   m_EditorClassIdentifier: 
   version: 1
-  m_DefaultScenePrefabSaved: {fileID: 4893056312182120781, guid: a1dfdae16e0448542a6124642d4c13e9,
-    type: 3}
-  m_DefaultDXRScenePrefabSaved: {fileID: 0}
   m_ProjectSettingFolderPath: HDRPDefaultResources
   m_WizardPopupAtStart: 0
   m_WizardPopupAlreadyShownOnce: 0

TestProjects/HDRP_Tests/ProjectSettings/QualitySettings.asset

@@ -27,7 +27,7 @@ QualitySettings:
     realtimeReflectionProbes: 1
     billboardsFaceCameraPosition: 1
     vSyncCount: 1
-    lodBias: 2
+    lodBias: 1
     maximumLODLevel: 0
     streamingMipmapsActive: 0
     streamingMipmapsAddAllCameras: 1

com.unity.render-pipelines.core/Editor/CoreEditorUtils.cs

@@ -448,6 +448,18 @@ public static bool DrawSubHeaderFoldout(GUIContent title, bool state, bool isBox
         /// <param name="hasMoreOptions">Delegate saying if we have MoreOptions</param>
         /// <param name="toggleMoreOptions">Callback called when the MoreOptions is toggled</param>
         /// <returns>return the state of the foldout header</returns>
+        public static bool DrawHeaderToggle(string title, SerializedProperty group, SerializedProperty activeField, Action<Vector2> contextAction = null, Func<bool> hasMoreOptions = null, Action toggleMoreOptions = null)
+            => DrawHeaderToggle(EditorGUIUtility.TrTextContent(title), group, activeField, contextAction, hasMoreOptions, toggleMoreOptions, null);
+
+        /// <summary>Draw a header toggle like in Volumes</summary>
+        /// <param name="title"> The title of the header </param>
+        /// <param name="group"> The group of the header </param>
+        /// <param name="activeField">The active field</param>
+        /// <param name="contextAction">The context action</param>
+        /// <param name="hasMoreOptions">Delegate saying if we have MoreOptions</param>
+        /// <param name="toggleMoreOptions">Callback called when the MoreOptions is toggled</param>
+        /// <param name="documentationURL">Documentation URL</param>
+        /// <returns>return the state of the foldout header</returns>
         public static bool DrawHeaderToggle(string title, SerializedProperty group, SerializedProperty activeField, Action<Vector2> contextAction = null, Func<bool> hasMoreOptions = null, Action toggleMoreOptions = null, string documentationURL = null)
             => DrawHeaderToggle(EditorGUIUtility.TrTextContent(title), group, activeField, contextAction, hasMoreOptions, toggleMoreOptions, documentationURL);
 
@@ -459,6 +471,17 @@ public static bool DrawHeaderToggle(string title, SerializedProperty group, Seri
         /// <param name="hasMoreOptions">Delegate saying if we have MoreOptions</param>
         /// <param name="toggleMoreOptions">Callback called when the MoreOptions is toggled</param>
         /// <returns>return the state of the foldout header</returns>
+        public static bool DrawHeaderToggle(GUIContent title, SerializedProperty group, SerializedProperty activeField, Action<Vector2> contextAction = null, Func<bool> hasMoreOptions = null, Action toggleMoreOptions = null)
+         => DrawHeaderToggle(title, group, activeField, contextAction, hasMoreOptions, toggleMoreOptions, null);
+        /// <summary>Draw a header toggle like in Volumes</summary>
+        /// <param name="title"> The title of the header </param>
+        /// <param name="group"> The group of the header </param>
+        /// <param name="activeField">The active field</param>
+        /// <param name="contextAction">The context action</param>
+        /// <param name="hasMoreOptions">Delegate saying if we have MoreOptions</param>
+        /// <param name="toggleMoreOptions">Callback called when the MoreOptions is toggled</param>
+        /// <param name="documentationURL">Documentation URL</param>
+        /// <returns>return the state of the foldout header</returns>
         public static bool DrawHeaderToggle(GUIContent title, SerializedProperty group, SerializedProperty activeField, Action<Vector2> contextAction = null, Func<bool> hasMoreOptions = null, Action toggleMoreOptions = null, string documentationURL = null)
         {
             var backgroundRect = GUILayoutUtility.GetRect(1f, 17f);

com.unity.render-pipelines.core/Runtime/Camera/FreeCamera.cs

@@ -35,6 +35,7 @@ public class FreeCamera : MonoBehaviour
         /// </summary>
         public float m_Turbo = 10.0f;
 
+#if !USE_INPUT_SYSTEM
         private static string kMouseX = "Mouse X";
         private static string kMouseY = "Mouse Y";
         private static string kRightStickX = "Controller Right Stick X";
@@ -44,6 +45,7 @@ public class FreeCamera : MonoBehaviour
 
         private static string kYAxis = "YAxis";
         private static string kSpeedAxis = "Speed Axis";
+#endif
 
 #if USE_INPUT_SYSTEM
         InputAction lookAction;