Fixed an issue where forced sky update (like PBR sky amortized updated) would not update ambient probe. (#6831)

Co-authored-by: sebastienlagarde <[email protected]>

Author: JulienIgnace-Unity

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -79,6 +79,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed a null ref exception in Volume Explorer
 - Fixed one frame flicker on hardware DRS - (case 1398085)
 - Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination.
+- Fixed an issue where forced sky update (like PBR sky amortized updated) would not update ambient probe.
 
 ## [14.0.0] - 2021-11-17
 

com.unity.render-pipelines.high-definition/Runtime/Sky/SkyManager.cs

@@ -1066,12 +1066,11 @@ void UpdateEnvironment(
                     {
                         var skyCubemap = GenerateSkyCubemap(renderGraph, hdCamera, skyContext);
 
-                        if (updateAmbientProbe && !renderingContext.computeAmbientProbeRequested)
+                        if (updateAmbientProbe)
                         {
                             UpdateAmbientProbe(renderGraph, skyCubemap, outputForClouds: false,
                                 renderingContext.ambientProbeResult, renderingContext.diffuseAmbientProbeBuffer, renderingContext.volumetricAmbientProbeBuffer,
                                 hdCamera.volumeStack.GetComponent<Fog>(), renderingContext.OnComputeAmbientProbeDone);
-                            renderingContext.computeAmbientProbeRequested = true;
                         }
 
                         if (renderingContext.supportsConvolution)

com.unity.render-pipelines.high-definition/Runtime/Sky/SkyRenderingContext.cs

@@ -17,7 +17,6 @@ internal class SkyRenderingContext
         public bool supportsConvolution { get; private set; } = false;
 
         internal bool ambientProbeIsReady = false;
-        public bool computeAmbientProbeRequested = false;
 
         public SkyRenderingContext(int resolution, int bsdfCount, bool supportsConvolution, SphericalHarmonicsL2 ambientProbe, string name)
         {
@@ -51,7 +50,6 @@ public SkyRenderingContext(int resolution, int bsdfCount, bool supportsConvoluti
         public void Reset()
         {
             ambientProbeIsReady = false;
-            computeAmbientProbeRequested = false;
         }
 
         public void Cleanup()