[7.x.x] backport #349 fix renderpass list (#468)

Author: martint-unity

com.unity.render-pipelines.universal/CHANGELOG.md

@@ -40,6 +40,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed UI text of RenderObjects feature to display LightMode tag instead of Shader Pass Name. [case 1201696](https://issuetracker.unity3d.com/issues/render-feature-slash-pass-ui-has-a-field-for-shader-pass-name-when-it-actually-expects-shader-pass-lightmode).
 - Fixed an issue that caused memory allocations when sorting cameras. [case 1226448](https://issuetracker.unity3d.com/issues/2d-renderer-using-more-than-one-camera-that-renders-out-to-a-render-texture-creates-gc-alloc-every-frame).
 - Fixed an issue that caused the inverse view and projection matrix to output wrong values on some platforms. [case 1243990](https://issuetracker.unity3d.com/issues/urp-8-dot-1-breaks-unity-matrix-i-vp).
+- Fixed an issue with not being able to remove Light Mode Tags [case 1240895](https://issuetracker.unity3d.com/issues/urp-unable-to-remove-added-lightmode-tags-of-filters-property-in-render-object)
 
 ## [7.3.0] - 2020-03-11
 

com.unity.render-pipelines.universal/Editor/RendererFeatures/RenderObjectsPassFeatureEditor.cs

@@ -71,7 +71,6 @@ internal class Styles
 	    private SerializedProperty m_CameraOffset;
 	    private SerializedProperty m_RestoreCamera;
 
-	    private ReorderableList m_ShaderPassesList;
         private List<SerializedObject> m_properties = new List<SerializedObject>();
 
         private void Init(SerializedProperty property)
@@ -111,25 +110,6 @@ private void Init(SerializedProperty property)
             m_RestoreCamera = m_CameraSettings.FindPropertyRelative("restoreCamera");
 
             m_properties.Add(property.serializedObject);
-            CreateShaderPassList();
-        }
-
-        private void CreateShaderPassList()
-        {
-            m_ShaderPassesList = new ReorderableList(null, m_ShaderPasses, false, true, true, true);
-
-            m_ShaderPassesList.drawElementCallback =
-            (Rect rect, int index, bool isActive, bool isFocused) =>
-            {
-                var element = m_ShaderPassesList.serializedProperty.GetArrayElementAtIndex(index);
-                var propRect = new Rect(rect.x, rect.y, rect.width, EditorGUIUtility.singleLineHeight);
-                element.stringValue = EditorGUI.TextField(propRect, "", element.stringValue);
-            };
-
-            m_ShaderPassesList.drawHeaderCallback = (Rect testHeaderRect) =>
-            {
-                EditorGUI.LabelField(testHeaderRect, Styles.shaderPassFilter);
-            };
         }
 
         public override void OnGUI(Rect rect, SerializedProperty property, GUIContent label)
@@ -198,9 +178,9 @@ void DoFilters(ref Rect rect)
 			    EditorGUI.PropertyField(rect, m_LayerMask, Styles.layerMask);
 			    rect.y += Styles.defaultLineSpace;
 			    //Shader pass list
+                EditorGUI.PropertyField(rect, m_ShaderPasses, Styles.shaderPassFilter, true);
+                rect.y += EditorGUI.GetPropertyHeight(m_ShaderPasses);
 			    EditorGUI.indentLevel--;
-			    m_ShaderPassesList.DoList(rect);
-			    rect.y += m_ShaderPassesList.GetHeight();
 		    }
 	    }
 
@@ -267,7 +247,7 @@ public override float GetPropertyHeight(SerializedProperty property, GUIContent
 
 		    Init(property);
             height += Styles.defaultLineSpace * (m_FiltersFoldout.value ? m_FilterLines : 1);
-            height += m_FiltersFoldout.value ? m_ShaderPassesList.GetHeight() : 0;
+            height += m_FiltersFoldout.value ? EditorGUI.GetPropertyHeight(m_ShaderPasses) : 0;
 
             height += Styles.defaultLineSpace; // add line for overrides dropdown
             if (m_RenderFoldout.value)