Add support for lighting full screen debug mode for HDRP tests #4367

Author: remi-chapelain

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -6,8 +6,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [10.6.0] - 2021-04-29
 
-Version Updated
-The version number for this package has increased due to a version update of a related graphics package.
+### Added
+- Added support for lighting full screen debug mode in automated tests.
 
 ## [10.5.0] - 2021-04-19
 

com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs

@@ -298,6 +298,11 @@ internal void ResetExclusiveEnumIndices()
         /// <summary>List of Full Screen Rendering Debug mode values.</summary>
         public static int[] renderingFullScreenDebugValues => s_RenderingFullScreenDebugValues;
 
+        /// <summary>List of Full Screen Lighting Debug mode names.</summary>
+        public static GUIContent[] lightingFullScreenDebugStrings => s_LightingFullScreenDebugStrings;
+        /// <summary>List of Full Screen Lighting Debug mode values.</summary>
+        public static int[] lightingFullScreenDebugValues => s_LightingFullScreenDebugValues;
+
         internal DebugDisplaySettings()
         {
             FillFullScreenDebugEnum(ref s_LightingFullScreenDebugStrings, ref s_LightingFullScreenDebugValues, FullScreenDebugMode.MinLightingFullScreenDebug, FullScreenDebugMode.MaxLightingFullScreenDebug);

com.unity.testing.hdrp/Scripts/DebugViewController.cs

@@ -19,6 +19,7 @@ public enum SettingType { Material, Lighting, Rendering }
 
     [Header("Lighting")]
     [SerializeField] bool lightlayers = false;
+    [SerializeField] int lightingFullScreenDebugMode = 0;
 
     [ContextMenu("Set Debug View")]
     public void SetDebugView()
@@ -33,7 +34,8 @@ public void SetDebugView()
             case SettingType.Lighting:
                 hdPipeline.debugDisplaySettings.SetDebugLightLayersMode(lightlayers);
                 hdPipeline.debugDisplaySettings.data.lightingDebugSettings.debugLightLayersFilterMask = (DebugLightLayersMask)0b10111101;
-                break;
+				hdPipeline.debugDisplaySettings.SetFullScreenDebugMode((FullScreenDebugMode) lightingFullScreenDebugMode);
+				break;
             case SettingType.Rendering:
                 hdPipeline.debugDisplaySettings.SetFullScreenDebugMode((FullScreenDebugMode) fullScreenDebugMode);
                 break;

com.unity.testing.hdrp/Scripts/Editor/DebugViewController_Editor.cs

@@ -12,6 +12,7 @@ public class DebugViewController_Editor : Editor
 
     SerializedProperty s_gBuffer;
     SerializedProperty s_fullScreenDebugMode;
+    SerializedProperty s_lightingFullScreenDebugMode;
 
     SerializedProperty s_lightlayers;
 
@@ -21,6 +22,7 @@ public void OnEnable()
 
         s_gBuffer = serializedObject.FindProperty("gBuffer");
         s_fullScreenDebugMode = serializedObject.FindProperty("fullScreenDebugMode");
+        s_lightingFullScreenDebugMode = serializedObject.FindProperty("lightingFullScreenDebugMode");
         s_lightlayers = serializedObject.FindProperty("lightlayers");
     }
 
@@ -45,7 +47,8 @@ public override void OnInspectorGUI()
 
                 case DebugViewController.SettingType.Lighting:
                     s_lightlayers.boolValue = GUILayout.Toggle(s_lightlayers.boolValue, "Light Layers Visualization");
-                    break;
+                    s_lightingFullScreenDebugMode.intValue = EditorGUILayout.IntPopup(new GUIContent("Fullscreen Debug Mode"), s_lightingFullScreenDebugMode.intValue, DebugDisplaySettings.lightingFullScreenDebugStrings, DebugDisplaySettings.lightingFullScreenDebugValues);
+					break;
 
                 case DebugViewController.SettingType.Rendering:
                     s_fullScreenDebugMode.intValue = EditorGUILayout.IntPopup(new GUIContent("Fullscreen Debug Mode"), s_fullScreenDebugMode.intValue, DebugDisplaySettings.renderingFullScreenDebugStrings, DebugDisplaySettings.renderingFullScreenDebugValues);