Skip to content

Commit d738a68

Browse files
julienf-unityGitHub Enterprise
authored andcommitted
Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)
* Fix Texture2DArray and Cubemap exposition from sg in output mesh context * Add case to changelog
1 parent a7c57f4 commit d738a68

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

com.unity.visualeffectgraph/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
133133
- fixes the user created vfx default resources that were ignored unless loaded
134134
- fix crash when creating a loop in subgraph operators [Case 1251523](https://issuetracker.unity3d.com/product/unity/issues/guid/1251523/)
135135
- Normals with non uniform scales are correctly computed [Case 1246989](https://issuetracker.unity3d.com/product/unity/issues/guid/1246989/)
136+
- Fix exposed Texture2DArray and Cubemap types from shader graph not being taken into account in Output Mesh [Case 1265221](https://issuetracker.unity3d.com/product/unity/issues/guid/1265221/)
136137

137138
## [7.1.1] - 2019-09-05
138139
### Added

com.unity.visualeffectgraph/Editor/Models/Contexts/Implementations/VFXStaticMeshOutput.cs

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,18 @@ protected override IEnumerable<VFXPropertyWithValue> inputProperties
140140
case TextureDimension.Tex3D:
141141
propertyType = typeof(Texture3D);
142142
break;
143+
case TextureDimension.Cube:
144+
propertyType = typeof(Cubemap);
145+
break;
146+
case TextureDimension.Tex2DArray:
147+
propertyType = typeof(Texture2DArray);
148+
break;
149+
case TextureDimension.CubeArray:
150+
propertyType = typeof(CubemapArray);
151+
break;
143152
default:
144-
break; // TODO
145-
}
153+
break;
154+
}
146155
propertyValue = mat.GetTexture(propertyNameId);
147156
break;
148157
}

0 commit comments

Comments
 (0)