[Test] Add test to cover "Thread Group Size" error (#104)

* Add test

* Add test to cover behavior from case 1271839

Author: PaulDemeulenaere

TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXComponentTest.cs

@@ -1167,6 +1167,39 @@ void fnSet_UsingSerializedProperty(VFXValueType type, VisualEffect vfx, string n
             VFXValueType.Matrix4x4
         };
 
+        public struct VFXNullableTest
+        {
+            internal VFXValueType type;
+            public override string ToString()
+            {
+                return type.ToString();
+            }
+        }
+
+        private static bool IsTypeNullable(Type type)
+        {
+            if (!type.IsValueType)
+                return true;
+            if (Nullable.GetUnderlyingType(type) != null)
+                return true; 
+            return false;
+        }
+
+#pragma warning disable 0414
+        private static VFXNullableTest[] nullableTestCase = s_supportedValueType.Where(o => IsTypeNullable(VFXValue.TypeToType(o))).Select(o => new VFXNullableTest() { type = o }).ToArray();
+#pragma warning restore 0414
+
+        [UnityTest]
+        public IEnumerator Check_SetNullable_Throw_An_Exception_While_Using_Null([ValueSource("nullableTestCase")] VFXNullableTest valueType)
+        {
+
+            while (m_mainObject.GetComponent<VisualEffect>() != null)
+                UnityEngine.Object.DestroyImmediate(m_mainObject.GetComponent<VisualEffect>());
+            var vfx = m_mainObject.AddComponent<VisualEffect>();
+            yield return null;
+            Assert.Throws<System.ArgumentNullException>(() => fnSet_UsingBindings(valueType.type, vfx, "null", null));
+        }
+
         [UnityTest]
         public IEnumerator CreateComponentWithAllBasicTypeExposed([ValueSource("trueOrFalse")] bool linkMode, [ValueSource("trueOrFalse")] bool bindingModes)
         {

TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXSpawnerTest.cs

@@ -49,6 +49,11 @@ private void CreateAssetAndComponent(float spawnCountValue, string playEventName
             var spawnerInit = ScriptableObject.CreateInstance<VFXBasicInitialize>();
             var spawnerOutput = ScriptableObject.CreateInstance<VFXPlanarPrimitiveOutput>();
 
+            var blockAttributeDesc = VFXLibrary.GetBlocks().FirstOrDefault(o => o.modelType == typeof(Block.SetAttribute));
+            var blockAttribute = blockAttributeDesc.CreateInstance();
+            blockAttribute.SetSettingValue("attribute", "position");
+            spawnerInit.AddChild(blockAttribute);
+
             slotCount.value = spawnCountValue;
 
             spawnerContext.AddChild(blockConstantRate);
@@ -406,6 +411,47 @@ public IEnumerator Create_Spawner_Check_Time_Mode_Update_Count([ValueSource("s_C
             yield return new ExitPlayMode();
         }
 
+        //Cover fix from 1268360 : Simple usage of exact fixed time step, it should not throw any error from the renderer
+        [UnityTest]
+        public IEnumerator Create_Spawner_Check_No_Incorrect_Thread_Count([ValueSource("s_CheckTimeMode")] VFXTimeModeTest timeMode)
+        {
+            yield return new EnterPlayMode();
+
+            var spawnCountValue = 651.0f;
+            VisualEffect vfxComponent;
+            GameObject cameraObj, gameObj;
+            VFXGraph graph;
+            CreateAssetAndComponent(spawnCountValue, "OnPlay", out graph, out vfxComponent, out gameObj, out cameraObj);
+            graph.GetResource().updateMode = (VFXUpdateMode)timeMode.vfxUpdateMode;
+            AssetDatabase.ImportAsset(AssetDatabase.GetAssetPath(graph));
+
+            var previousCaptureFrameRate = Time.captureFramerate;
+            var previousFixedTimeStep = UnityEngine.VFX.VFXManager.fixedTimeStep;
+            var previousMaxDeltaTime = UnityEngine.VFX.VFXManager.maxDeltaTime;
+
+            UnityEngine.VFX.VFXManager.fixedTimeStep = 0.1f;
+            UnityEngine.VFX.VFXManager.maxDeltaTime = 0.5f;
+            Time.captureDeltaTime = 1.0f;
+
+            int maxFrame = 128;
+            while (vfxComponent.culled && --maxFrame > 0)
+                yield return null;
+
+            //Wait a few frame to verify if we are getting any warning from the rendering
+            for (int i = 0; i < 5; ++i)
+                yield return null;
+
+            UnityEngine.Object.DestroyImmediate(gameObj);
+            UnityEngine.Object.DestroyImmediate(cameraObj);
+
+            Time.captureFramerate = previousCaptureFrameRate;
+            UnityEngine.VFX.VFXManager.fixedTimeStep = previousFixedTimeStep;
+            UnityEngine.VFX.VFXManager.maxDeltaTime = previousMaxDeltaTime;
+
+            yield return new ExitPlayMode();
+        }
+
+
         //Fix case 1217876
         static VFXTimeModeTest[] s_Change_Fixed_Time_Step_To_A_Large_Value_Then_Back_To_Default = new[]
         {