Revert "Fixed an exception thrown when closing the lookdev because there is no active SRP anymore. (#1925)"

This reverts commit 5388f4a.

Author: sebastienlagarde

com.unity.render-pipelines.core/Editor/LookDev/DisplayWindow.cs

@@ -625,19 +625,6 @@ IStyle GetEnvironmentContenairDraggerStyle()
             }
         }
 
-        void Update()
-        {
-            // [case 1245086] Guard in case the SRP asset is set to null (or to a not supported SRP) when the lookdev window is already open
-            // Note: After an editor reload, we might get a null OnUpdateRequestedInternal and null SRP for a couple of frames, hence the check.
-            if (!LookDev.supported && OnUpdateRequestedInternal != null)
-            {
-                // Print an error and close the Lookdev window (to avoid spamming the console)
-                Debug.LogError($"LookDev is not supported by this Scriptable Render Pipeline: "
-                    + (RenderPipelineManager.currentPipeline == null ? "No SRP in use" : RenderPipelineManager.currentPipeline.ToString()));
-                LookDev.Close();
-            }
-        }
-
         void OnGUI()
         {
             //Stylesheet
@@ -703,6 +690,17 @@ void OnGUI()
                     rootVisualElement.styleSheets.Add(styleSheetLight);
             }
 
+            // [case 1245086] Guard in case the SRP asset is set to null (or to a not supported SRP) when the lookdev window is already open
+            // Note: After an editor reload, we might get a null OnUpdateRequestedInternal and null SRP for a couple of frames, hence the check.
+            if (!LookDev.supported && OnUpdateRequestedInternal !=null)
+            {
+                // Print an error and close the Lookdev window (to avoid spamming the console)
+                Debug.LogError($"LookDev is not supported by this Scriptable Render Pipeline: "
+                    + (RenderPipelineManager.currentPipeline == null ? "No SRP in use" : RenderPipelineManager.currentPipeline.ToString()));
+                LookDev.Close();
+                return;
+            }
+
             OnUpdateRequestedInternal?.Invoke();
         }
     }

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -91,7 +91,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed serialization issue with matcap scale intensity.
 - Close Add Override popup of Volume Inspector when the popup looses focus (case 1258571)
 - Light quality setting for contact shadow set to on for High quality by default.
-- Fixed an exception thrown when closing the look dev because there is no active SRP anymore.
 
 ### Changed
 - Preparation pass for RTSSShadows to be supported by render graph.