GFXGI-237: Force update for static skies when camera type is set to S… #1570

Author: i9neus

com.unity.render-pipelines.high-definition/Runtime/Sky/SkyManager.cs

@@ -815,8 +815,10 @@ public void UpdateEnvironment(HDCamera hdCamera, ScriptableRenderContext renderC
             StaticLightingSky staticLightingSky = GetStaticLightingSky();
 #if UNITY_EDITOR
             // In the editor, we might need the static sky ready for baking lightmaps/lightprobes regardless of the current ambient mode so we force it to update in this case if it's not been computed yet..
-            // We don't test if the hash of the static sky has changed here because it depends on the sun direction and in the case of LookDev, sun will be different from the main rendering so it will induce improper recomputation.
-            forceStaticUpdate = staticLightingSky != null && m_StaticLightingSky.skyParametersHash == -1; ;
+            // We always force an update of the static sky when we're in scene view mode. Previous behaviour was to prevent forced updates if the hash of the static sky was non-null, but this was preventing
+            // the lightmapper from updating in response to changes in environment. See GFXGI-237 for a better description of this issue.
+
+            forceStaticUpdate = hdCamera.camera.cameraType == CameraType.SceneView;
 #endif
             if ((ambientMode == SkyAmbientMode.Static || forceStaticUpdate) && hdCamera.camera.cameraType != CameraType.Preview)
             {