New DGI validity baking and ProbeVolume interface (#66)

* Added a button to Probe Volume to bake dynamic GI without the lightmapper. Then, validity is computed with the same rays that used for hits, so it only "sees" backfaces that are one voxel away or closer.
* Simplified IProbeVolumeList by grouping all runtime data the pipeline may need to write to into ProbeVolumePipelineData and ProbeVolumePropagationPipelineData structs.
* Replaced single dataUpdated on ProbeVolume with dataVersion on ProbeVolumeAsset to detect changes of baked data for already loaded volumes and keep baked lighting buffers, dynamic lighting buffers, atlas slot and content — all up to date regardless of the order they are used.

Author: AndrewSaraevUnity

com.unity.render-pipelines.high-definition/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Drawer.cs

@@ -105,6 +105,17 @@ static void Drawer_BakeToolBar(SerializedProbeVolume serialized, Editor owner)
             {
                 ProbeVolumeManager.BakeSelected();
             }
+            if (GUILayout.Button(Styles.k_BakeDynamicGIOnlyText))
+            {
+                var targets = serialized.GetTargetObjects();
+                for (int i = 0; i < targets.Length; i++)
+                {
+                    var probeVolume = (ProbeVolume)targets[i];
+                    EditorUtility.DisplayProgressBar("Baking Dynamic GI", $"{i + 1}/{targets.Length} {probeVolume.name}", (i + 0.5f) / targets.Length);
+                    probeVolume.BakeDynamicGIOnly();
+                }
+                EditorUtility.ClearProgressBar();
+            }
             GUILayout.EndHorizontal();
         }
 

com.unity.render-pipelines.high-definition/Editor/Lighting/ProbeVolume/ProbeVolumeUI.Skin.cs

@@ -15,6 +15,7 @@ internal static class Styles
             internal const string k_ProbesHeader = "Probes";
             internal const string k_BakingHeader = "Baking";
             internal const string k_BakeSelectedText = "Bake Selected";
+            internal const string k_BakeDynamicGIOnlyText = "Bake Dynamic GI Only";
 
             internal static readonly GUIContent[] s_Toolbar_Contents = new GUIContent[]
             {

com.unity.render-pipelines.high-definition/Editor/Lighting/ProbeVolume/SerializedProbeVolume.cs

@@ -106,5 +106,10 @@ internal void Apply()
         {
             m_SerializedObject.ApplyModifiedProperties();
         }
+
+        internal UnityEngine.Object[] GetTargetObjects()
+        {
+            return m_SerializedObject.targetObjects;
+        }
     }
 }

com.unity.render-pipelines.high-definition/Runtime/Lighting/ProbeVolume/DynamicGI/ProbeVolumeDynamicGI.cs

@@ -1,5 +1,3 @@
-using static UnityEngine.Rendering.HighDefinition.VolumeGlobalUniqueIDUtils;
-
 namespace UnityEngine.Rendering.HighDefinition
 {
     interface IProbeVolumeList
@@ -9,45 +7,32 @@ interface IProbeVolumeList
 
         bool IsAssetCompatible(int i);
         bool IsDataAssigned(int i);
-        bool IsDataUpdated(int i);
-        void SetDataUpdated(int i, bool value);
+        int GetDataVersion(int i);
+        void IncrementDataVersion(int i);
 
         Vector3 GetPosition(int i);
         Quaternion GetRotation(int i);
 
-        ref ProbeVolumeArtistParameters GetParameters(int i);
+        ProbeVolumeArtistParameters GetParameters(int i);
 
-        VolumeGlobalUniqueID GetAtlasID(int i);
         ProbeVolume.ProbeVolumeAtlasKey ComputeProbeVolumeAtlasKey(int i);
-        ProbeVolume.ProbeVolumeAtlasKey GetProbeVolumeAtlasKeyPrevious(int i);
-        void SetProbeVolumeAtlasKeyPrevious(int i, ProbeVolume.ProbeVolumeAtlasKey key);
 
         int GetDataSHL01Length(int i);
         int GetDataSHL2Length(int i);
-        int GetDataValidityLength(int i);
         int GetDataOctahedralDepthLength(int i);
 
         void SetDataOctahedralDepth(int i, ComputeBuffer buffer);
 
         public void EnsureVolumeBuffers(int i);
-        public void SetVolumeBuffers(int i);
-        public ProbeVolumeBuffers GetVolumeBuffers(int i);
+        public ref ProbeVolumePipelineData GetPipelineData(int i);
 
         // Dynamic GI
-        int GetProbeVolumeEngineDataIndex(int i);
-        OrientedBBox GetProbeVolumeEngineDataBoundingBox(int i);
-        ProbeVolumeEngineData GetProbeVolumeEngineData(int i);
-        void ClearProbeVolumeEngineData(int i);
-        void SetProbeVolumeEngineData(int i, int dataIndex, in OrientedBBox box, in ProbeVolumeEngineData data);
-        OrientedBBox ConstructOBBEngineData(int i, Vector3 camOffset);
-        ref ProbePropagationBuffers GetPropagationBuffers(int i);
+        ref ProbeVolumePropagationPipelineData GetPropagationPipelineData(int i);
         bool HasNeighbors(int i);
         int GetHitNeighborAxisLength(int i);
         int GetNeighborAxisLength(int i);
         void SetHitNeighborAxis(int i, ComputeBuffer buffer);
         void SetNeighborAxis(int i, ComputeBuffer buffer);
-        void SetLastSimulatedFrame(int i, int simulationFrameTick);
-        int GetLastSimulatedFrame(int i);
 
 #if UNITY_EDITOR
         public bool IsHiddenInScene(int i);