Unity-Technologies
diff --git a/‎.gitattributes‎
Lines changed: 2 additions & 0 deletions b/‎.gitattributes‎
Lines changed: 2 additions & 0 deletions
diff --git a/‎.github/CODEOWNERS‎
Lines changed: 2 additions & 1 deletion b/‎.github/CODEOWNERS‎
Lines changed: 2 additions & 1 deletion
diff --git a/‎.github/PULL_REQUEST_TEMPLATE.md‎
Lines changed: 11 additions & 25 deletions b/‎.github/PULL_REQUEST_TEMPLATE.md‎
Lines changed: 11 additions & 25 deletions
diff --git a/‎.github/pr-read-override.css‎
Lines changed: 6 additions & 0 deletions b/‎.github/pr-read-override.css‎
Lines changed: 6 additions & 0 deletions
diff --git a/‎.github/pr-read.png‎
Lines changed: 3 additions & 0 deletions b/‎.github/pr-read.png‎
Lines changed: 3 additions & 0 deletions
diff --git a/‎.github/pr-read.png.css‎
Lines changed: 26 additions & 0 deletions b/‎.github/pr-read.png.css‎
Lines changed: 26 additions & 0 deletions
diff --git a/‎.github/pr-read.png.md‎
Lines changed: 20 additions & 0 deletions b/‎.github/pr-read.png.md‎
Lines changed: 20 additions & 0 deletions
diff --git a/‎.github/workflows/draft.yml‎
Lines changed: 20 additions & 0 deletions b/‎.github/workflows/draft.yml‎
Lines changed: 20 additions & 0 deletions
diff --git a/‎.github/workflows/labeler.yml‎
Lines changed: 0 additions & 1 deletion b/‎.github/workflows/labeler.yml‎
Lines changed: 0 additions & 1 deletion
diff --git a/‎.gitignore‎
Lines changed: 6 additions & 0 deletions b/‎.gitignore‎
Lines changed: 6 additions & 0 deletions
@@ -1,3 +1,5 @@
+*       text=auto
+
 # Unity assets are always serialized using lf endings
 LightingData.asset binary
 *.unitypackage filter=lfs diff=lfs merge=lfs -text
 
@@ -10,11 +10,12 @@
 /com.unity.render-pipelines.universal/Editor/ShaderGraph/MasterNodes @Unity-Technologies/2d-graphics
 
 # Shader Graph
-/com.unity.shadergraph/ @Unity-Technologies/shader-graph @Unity-Technologies/gfx-qa-bellevue
+/com.unity.shadergraph/ @Unity-Technologies/shader-graph
 
 # Test systems
 /.yamato/ @Unity-Technologies/gfx-sdets
 /katana-ci/ @Unity-Technologies/gfx-sdets
+/Tools/ @Unity-Technologies/gfx-sdets
 /com.unity.testframework.graphics/ @Unity-Technologies/gfx-sdets
 
 # LWRP (Legacy)
 
@@ -1,15 +1,16 @@
-### **Please read**
-**PR workflow guidelines**
-* SRP ABV will start automatically when you open your PR
-* Changes to docs and md files will **not** trigger ABV jobs 
-* Consider making use of **draft PRs** if you are not 100% sure that your PR is ready for review
-* ABV will restart if you add a new commit to a branch with an open PR (hence why you should consider using draft PRs)
-* Adding [skip ci] (case insensitive) to the title of PRs will stop any jobs being trigger automatically - you will need to open Yamato and find your branch to run ABV
+# **Please read;**
+## **PR Workflow for the Graphics repository:**
+* **All PRs must be opened as draft initially**
+* Reviewers can be added while the PR is still in draft
+* The PR can be marked as “Ready for Review” once the reviewers have confirmed that **no more changes are needed**
+* Tests will start automatically after the PR is marked as “Ready for Review”
+* **Do not use [skip ci]** - this can break some of our tooling
+* Read the [Graphics repository & Yamato FAQ](http://go/graphics-yamato-faq).
 
 ### Checklist for PR maker
-- [ ] Have you added a backport label (if needed)? For example, the `need-backport-2019.3` label. After you backport the PR, the label changes to `backported-2019.3`.
+- [ ] Have you added a backport label (if needed)? For example, the `need-backport-*` label. After you backport the PR, the label changes to `backported-*`.
 - [ ] Have you updated the changelog? Each package has a `CHANGELOG.md` file.
-- [ ] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR.
+- [ ] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the [Docs team contacts sheet](https://docs.google.com/spreadsheets/d/1rgUWWgwLFEHIQ3Rz-LnK6PAKmbM49DZZ9al4hvnztOo/edit#gid=1058860420).
 - [ ] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.
 
 ---
@@ -18,22 +19,7 @@ Why is this PR needed, what hard problem is it solving/fixing?
 
 ---
 ### Testing status
-
-**Manual Tests**: What did you do?
-- [ ] Opened test project + Run graphic tests locally
-- [ ] Built a player
-- [ ] Checked new UI names with UX convention
-- [ ] Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
-- [ ] C# and shader warnings (supress shader cache to see them)
-- [ ] Checked new resources path for the reloader (in devloper mode, you have a button at end of resources that check the pathes)
-- Other: 
-
-**Automated Tests**: What did you setup? (Add a screenshot or the reference image of the test please)
-
-**Yamato**: (Select your branch):
-https://yamato.prd.cds.internal.unity3d.com/jobs/78-ScriptableRenderPipeline
-
-Any test projects to go with this to help reviewers?
+Describe what manual/automated tests were performed for this PR
 
 ---
 ### Comments to reviewers
 
@@ -0,0 +1,6 @@
+.pull-discussion-timeline>div:first-child>div:first-child .js-previewable-comment-form::before, .new-pr-form .js-previewable-comment-form::before
+{
+    display:block;
+    content: url("https://github.com/Unity-Technologies/Graphics/blob/master/.github/pr-read.png?raw=true");
+    height: auto;
+}
@@ -0,0 +1,26 @@
+@import "github.css";
+ 
+#write{
+	max-width: none;
+    width: 709px;
+  	margin: 0 auto;
+  	padding: 5px;
+	border: 20px solid #bda668;
+	min-height: auto !important;
+}
+#write > ul:first-child,
+#write > ol:first-child{
+    margin-top: 0px;
+}
+
+body > *:first-child {
+    margin-top: 0 !important;
+}
+body > *:last-child {
+    margin-bottom: 0 !important;
+}
+
+h1, h2, h3, h4, h5, h6
+{
+	width: auto !important;
+}
@@ -0,0 +1,20 @@
+# Please read
+## PR workflow guidelines
+- Consider making use of **draft PRs** if you are not 100% sure that your PR is ready for review
+- Adding [skip ci] (case insensitive) to the title of PRs will stop any jobs being triggered automatically - you will need to open Yamato and find your branch to run ABV
+- You can also add [skip ci] to commit messages to prevent CI from running on that push
+- Add [cancel old ci] to your commit message if you've made changes you want to test and no longer need the previous jobs
+
+## Reminders
+- Have you added a backport label (if needed)?
+  
+  > *For example, the `need-backport-*` label. After you backport the PR, the label changes to `backported-*`.*
+- Have you updated the changelog?
+  
+  > *Each package has a `CHANGELOG.md` file.*
+- Have you updated or added the documentation for your PR?
+  
+  > *When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR.*
+- Have you added a graphic test for your PR (if needed)?
+  
+  > *When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.*
@@ -0,0 +1,20 @@
+name: Draft reminder
+
+on:
+  pull_request:
+    types: [opened]
+
+jobs:
+  draft_reminder:
+    runs-on: ubuntu-latest
+    if: github.event.pull_request.draft == false && github.event.pull_request.ready_for_review == false
+    steps:
+    - uses: thollander/[email protected]
+      with:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        message: |
+              It appears that you made a non-draft PR!
+              Please convert your PR to draft (button on the right side of the page)
+              and cancel any jobs that started on Yamato.
+              See the PR template for more information.
+              Thank you!
@@ -7,7 +7,6 @@ jobs:
   label:
 
     runs-on: ubuntu-latest
-    if: github.event.pull_request.draft == false
     steps:
     - uses: actions/labeler@v2
       with:
 
@@ -19,6 +19,7 @@
 *.csproj
 *.exe
 *.ini
+*.log
 *.map
 *.mdb
 *.npmrc
@@ -30,9 +31,14 @@
 *.sublime-workspace
 *.suo
 *.userprefs
+*.orig
+*.orig.meta
 .npmrc
 ShaderGraph/DebugOutput.meta
 ShaderGraph/DebugOutput/**
 ShaderGraph/Testing/IntegrationTests/.Failed
 TestProjects/*/ProjectSettings/ProjectVersion.txt
+TestProjects/VisualEffectGraph_HDRP/GraphViz/
 
+*/manifest-updater.py
+node_modules
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+* text=auto`
	`2`	`+`
`1`	`3`	`# Unity assets are always serialized using lf endings`
`2`	`4`	`LightingData.asset binary`
`3`	`5`	`*.unitypackage filter=lfs diff=lfs merge=lfs -text`