Fix FreeCamera speed boost controls (#2967)

Two issues:

1. Holding Shift key during mouse-look with right mouse button would only boost speed for a single frame because it was checking GetKeyDown. Fixed by checking GetKey.

2. The Shift key only gives a speed boost when mouse-looking with RMB, but the Fire input (LMB by default) should always work. However, there was an issue where Fire would not boost the camera if the RMB was held down. This change fixes that so Fire will always boost and Shift will still only boost during mouse-look.

Author: akerfoot

com.unity.render-pipelines.core/CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ### Fixed
 - Fixed ACES tonemaping for Nintendo Switch by forcing some shader color conversion functions to full float precision.
+- Fixed a bug in FreeCamera which would only provide a speed boost for the first frame when pressing the Shfit key.
 
 ## [10.2.0] - 2020-10-19
 

com.unity.render-pipelines.core/Runtime/Camera/FreeCamera.cs

@@ -151,7 +151,7 @@ void UpdateInputs()
             inputRotateAxisX += (Input.GetAxis(kRightStickX) * m_LookSpeedController * Time.deltaTime);
             inputRotateAxisY += (Input.GetAxis(kRightStickY) * m_LookSpeedController * Time.deltaTime);
 
-            leftShift = Input.GetKeyDown(KeyCode.LeftShift);
+            leftShift = Input.GetKey(KeyCode.LeftShift);
             fire1 = Input.GetAxis("Fire1") > 0.0f;
 
             inputChangeSpeed = Input.GetAxis(kSpeedAxis);
@@ -192,10 +192,8 @@ void Update()
                 transform.localRotation = Quaternion.Euler(newRotationX, newRotationY, transform.localEulerAngles.z);
 
                 float moveSpeed = Time.deltaTime * m_MoveSpeed;
-                if (leftShiftBoost)
-                    moveSpeed *= leftShift ? m_Turbo : 1.0f;
-                else
-                    moveSpeed *= fire1 ? m_Turbo : 1.0f;
+                if (fire1 || leftShiftBoost && leftShift)
+                    moveSpeed *= m_Turbo;
                 transform.position += transform.forward * moveSpeed * inputVertical;
                 transform.position += transform.right * moveSpeed * inputHorizontal;
                 transform.position += Vector3.up * moveSpeed * inputYAxis;