Easy Wins (Small Workflow / Cosmetic fixes) (#37)

Author: Thomas Iché

com.unity.visualeffectgraph/CHANGELOG.md

@@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Added
+- Added Degrees / Radians conversion subgraphs in samples
+
 ### Fixed
 - Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.
 - Don't show the blocks window when context cant have blocks
@@ -16,6 +19,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Avoid other NullReferenceException using property binders
 - Fix culture issues when generating attributes defines in shaders [Case 1222819](https://issuetracker.unity3d.com/product/unity/issues/guid/1222819/)
 - Move the VFXPropertyBinder from Update to LateUpdate [Case 1254340](https://issuetracker.unity3d.com/product/unity/issues/guid/1254340/)
+- Properties in blackboard are now exposed by default
+- Dissociated Colors for bool, uint and int
+- De-nicified attribute name (conserve case) in Set Custom Attribute title
+- Changed the default "No Asset" message when opening the visual effect graph window
+- Subgraphs are not in hardcoded categories anymore : updated default subgraph templates + Samples to add meaningful categories.
 
 ## [7.5.0] - 2020-06-08
 

com.unity.visualeffectgraph/Documentation~/Blackboard.md

@@ -14,6 +14,12 @@ To differentiate between exposed properties and constants, the Blackboard displa
 
 To open the Blackboard, click the **Blackboard** button in the Visual Effect Graph window [Toolbar](VisualEffectGraphWindow.md#Toolbar). To resize the Blackboard, click on any edge or corner and drag. To reposition the Blackboard, click on the header and drag.
 
+### Menu Category
+
+In order to set the Menu path of the currently edited Subgraph, you can double-click the sub-title of the blackboard and enter the desired Category Name, then validate using the Return Key
+
+![Blackboard-Category](Images/Blackboard-Category.gif)
+
 ### Creating properties
 
 To create a property, click the plus (**+**) button in the top-right of the Blackboard then select a property type from the menu.

com.unity.visualeffectgraph/Documentation~/Images/Blackboard-Category.gif

@@ -30,7 +30,7 @@ You can create a System Subgraph using the following:
 * Selecting one or Many Systems in a Visual Effect Graph, then selecting "Convert to Subgraph" in the Right-Click context menu, then saving the Graph Asset in the Save File Dialog.
   * Creating a subgraph using this method will replace all converted content with a System Subgraph Node.
 
-### Editing Block Subgraphs
+### Editing System Subgraphs
 
 You can edit a System Subgraph by opening it in the Visual Effect Graph window:
 
@@ -79,6 +79,8 @@ Block Subgraphs display a non-removable Context named "Block Subgraph" where Blo
 * Context can be customized using the following Properties:
   * **Suitable Contexts** : Determine Which Context types are compatible with the Block Subgraph
 
+You can define the Menu Category the subgraph block will appear in the [Blackboard](Blackboard.md)
+
 ### Using Block Subgraphs
 
 You can add a Block Subgraph Node to your Graph:
@@ -117,6 +119,8 @@ You can set up Input and Output Properties for the Operator using the Blackboard
 * You can create **Input** Properties by adding new Properties and enabling their **Exposed** Flag.
 * You can create **Output** Properties by adding new Properties, and moving them to the **Output Category**.
 
+You can define the Menu Category the subgraph block will appear in the [Blackboard](Blackboard.md)
+
 ### Using Operator Subgraphs
 
 You can add an Operator Subgraph Node to your Graph:

com.unity.visualeffectgraph/Documentation~/Subgraph.md

@@ -22,11 +22,11 @@
 }
 .port.typeboolean
 {
-    --port-color: #9481E6;
+    --port-color: #d9b3ff;
 }
 .port.typeuint32
 {
-    --port-color: #9481E6;
+    --port-color: #6e55dd;
 }
 .port.typeflipbook
 {

com.unity.visualeffectgraph/Editor Default Resources/uss/VFXTypeColor.uss

@@ -123,7 +123,7 @@ public SubgraphBlockDescriptor(SubGraphCache.Item item)
                 this.item = item;
             }
 
-            public override string category { get { return "Subgraph Block/" + item.category; } }
+            public override string category { get { return item.category; } }
             public override string name { get { return item.name; } }
         }
 

com.unity.visualeffectgraph/Editor/FilterPopup/VFXBlockProvider.cs

@@ -358,6 +358,8 @@ void OnAddParameter(object parameter)
             VFXParameter newParam = m_Controller.AddVFXParameter(Vector2.zero, (VFXModelDescriptorParameters)parameter);
             if (selectedCategory != null && newParam != null)
                 newParam.category = selectedCategory.title;
+
+            newParam.SetSettingValue("m_Exposed", true);
         }
 
         void OnAddItem(Blackboard bb)

com.unity.visualeffectgraph/Editor/GraphView/Blackboard/VFXBlackboard.cs

@@ -202,7 +202,7 @@ protected override IEnumerable<Descriptor> GetDescriptors()
                     t => new Descriptor()
                     {
                         modelDescriptor = t.path,
-                        category = "Operator/Subgraph Operator/" + t.category,
+                        category = "Operator/" + t.category,
                         name = t.name
                     }
                 ));

com.unity.visualeffectgraph/Editor/GraphView/Views/VFXNodeProvider.cs

@@ -382,20 +382,19 @@ public VFXView()
 
             // End Toolbar
 
-            m_NoAssetLabel = new Label("Please Open An Asset") { name = "no-asset"};
+            m_NoAssetLabel = new Label("\n\n\nTo begin creating Visual Effects, create a new Visual Effect Graph Asset.\n(or double-click an existing Visual Effect Graph in the project view)") { name = "no-asset"};
             m_NoAssetLabel.style.position = PositionType.Absolute;
-            m_NoAssetLabel.style.left = 0f;
-            m_NoAssetLabel.style.right = new StyleLength(0f);
-            m_NoAssetLabel.style.top = new StyleLength(0f);
-            m_NoAssetLabel.style.bottom = new StyleLength(0f);
+            m_NoAssetLabel.style.left = new StyleLength(40f);
+            m_NoAssetLabel.style.right = new StyleLength(40f);
+            m_NoAssetLabel.style.top = new StyleLength(40f);
+            m_NoAssetLabel.style.bottom = new StyleLength(140f);
             m_NoAssetLabel.style.unityTextAlign = TextAnchor.MiddleCenter;
-            m_NoAssetLabel.style.fontSize = new StyleLength(72f);
+            m_NoAssetLabel.style.fontSize = new StyleLength(12f);
             m_NoAssetLabel.style.color = Color.white * 0.75f;
-
             Add(m_NoAssetLabel);
 
 
-            var createButton = new Button() { text = "Create Graph" };
+            var createButton = new Button() { text = "Create new Visual Effect Graph" };
             m_NoAssetLabel.Add(createButton);
             createButton.clicked += OnCreateAsset;
 

com.unity.visualeffectgraph/Editor/GraphView/Views/VFXView.cs

@@ -58,7 +58,7 @@ public override string name
         {
             get
             {
-                string attributeName = ObjectNames.NicifyVariableName(attribute);
+                string attributeName = attribute;
                 return VFXBlockUtility.GetNameString(Composition) + " " + attributeName + " " + VFXBlockUtility.GetNameString(Random) + " (" + AttributeType.ToString() + ")";
             }
         }