Fix Shader.SetGlobalX

Author: johnpars

com.unity.shadergraph/Editor/Data/Graphs/AbstractShaderProperty.cs

@@ -25,7 +25,14 @@ public bool gpuInstanced
         internal virtual string GetHLSLVariableName(bool isSubgraphProperty, GenerationMode mode)
         {
             if (mode == GenerationMode.VFX)
-                return $"PROP.{referenceName}";
+            {
+                // Per-element exposed properties are provided by the properties structure filled by VFX.
+                if (overrideHLSLDeclaration)
+                    return $"PROP.{referenceName}";
+                // For un-exposed global properties, just read from the cbuffer.
+                else
+                    return referenceName;
+            }
 
             return referenceName;
         }

com.unity.shadergraph/Editor/Data/Graphs/GraphData.cs

@@ -1220,7 +1220,7 @@ public void CollectShaderProperties(PropertyCollector collector, GenerationMode
             {
                 // For VFX Shader generation, we must omit exposed properties from the Material CBuffer.
                 // This is because VFX computes properties on the fly in the vertex stage, and packed into interpolator.
-                if (generationMode == GenerationMode.VFX)
+                if (generationMode == GenerationMode.VFX && prop.isExposed)
                 {
                     prop.overrideHLSLDeclaration = true;
                     prop.hlslDeclarationOverride = HLSLDeclaration.DoNotDeclare;