New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

Author: PaulDemeulenaere

TestProjects/VisualEffectGraph/Assets/AllTests/Editor/Tests/VFXCustomSpawnerSample.cs

@@ -2,7 +2,7 @@
 using UnityEngine;
 using UnityEngine.VFX;
 
-namespace UnityEditor.VFX
+namespace UnityEditor.VFX.Test
 {
     class VFXCustomSpawnerSample : VFXSpawnerCallbacks
     {

TestProjects/VisualEffectGraph/Assets/AllTests/Editor/Tests/VFXCustomSpawnerTest.cs

@@ -2,7 +2,7 @@
 using UnityEngine;
 using UnityEngine.VFX;
 
-namespace UnityEditor.VFX
+namespace UnityEditor.VFX.Test
 {
     class VFXCustomSpawnerTest : VFXSpawnerCallbacks
     {

TestProjects/VisualEffectGraph/Assets/AllTests/Editor/Tests/VFXCustomSpawnerTimeCheckerTest.cs

@@ -0,0 +1,33 @@
+using System;
+using UnityEngine;
+using UnityEngine.VFX;
+
+namespace UnityEditor.VFX.Test
+{
+    class VFXCustomSpawnerTimeCheckerTest : VFXSpawnerCallbacks
+    {
+        static public float s_ReadTotalTimeThroughInput = -571.0f;
+        static public float s_ReadInternalTotalTime = -27.0f;
+
+        public class InputProperties
+        {
+            public float totalTime = 86;
+        }
+
+        public override void OnPlay(VFXSpawnerState state, VFXExpressionValues vfxValues, VisualEffect vfxComponent)
+        {
+        }
+
+
+        static private int s_totalTimeID = Shader.PropertyToID("totalTime");
+        public override void OnUpdate(VFXSpawnerState state, VFXExpressionValues vfxValues, VisualEffect vfxComponent)
+        {
+            s_ReadTotalTimeThroughInput = vfxValues.GetFloat(s_totalTimeID);
+            s_ReadInternalTotalTime = state.totalTime;
+        }
+
+        public override void OnStop(VFXSpawnerState state, VFXExpressionValues vfxValues, VisualEffect vfxComponent)
+        {
+        }
+    }
+}

TestProjects/VisualEffectGraph/Assets/AllTests/Editor/Tests/VFXCustomSpawnerTimeCheckerTest.cs.meta

@@ -2,7 +2,7 @@
 using UnityEngine;
 using UnityEngine.VFX;
 
-namespace UnityEditor.VFX
+namespace UnityEditor.VFX.Test
 {
     class VFXCustomSpawnerUpdateCounterTest : VFXSpawnerCallbacks
     {

TestProjects/VisualEffectGraph/Assets/AllTests/Editor/Tests/VFXCustomSpawnerUpdateCounterTest.cs

@@ -100,6 +100,72 @@ public IEnumerator Create_Asset_And_Component_Check_Expected_TotalTime()
             yield return new ExitPlayMode();
         }
 
+        [UnityTest]
+        public IEnumerator Check_Total_Time_Is_Always_The_Sum_of_DeltaTime()
+        {
+            yield return new EnterPlayMode();
+            var graph = VFXTestCommon.MakeTemporaryGraph();
+
+            var spawnerContext = ScriptableObject.CreateInstance<VFXBasicSpawner>();
+
+            var blockCustomSpawner = ScriptableObject.CreateInstance<VFXSpawnerCustomWrapper>();
+            blockCustomSpawner.SetSettingValue("m_customType", new SerializableType(typeof(VFXCustomSpawnerTimeCheckerTest)));
+
+            var initContext = ScriptableObject.CreateInstance<VFXBasicInitialize>();
+            var outputContext = ScriptableObject.CreateInstance<VFXPointOutput>();
+
+            spawnerContext.LinkTo(initContext);
+            initContext.LinkTo(outputContext);
+
+            spawnerContext.AddChild(blockCustomSpawner);
+            graph.AddChild(spawnerContext);
+            graph.AddChild(initContext);
+            graph.AddChild(outputContext);
+
+            //plug total time into custom spawn total time
+            var builtInParameter = ScriptableObject.CreateInstance<VFXBuiltInParameter>();
+            builtInParameter.SetSettingValue("m_expressionOp", VFXExpressionOperation.TotalTime);
+            blockCustomSpawner.inputSlots[0].Link(builtInParameter.outputSlots[0]);
+
+            graph.AddChild(builtInParameter);
+
+            AssetDatabase.ImportAsset(AssetDatabase.GetAssetPath(graph));
+
+            var vfxComponent = m_gameObject.AddComponent<VisualEffect>();
+            vfxComponent.visualEffectAsset = graph.visualEffectResource.asset;
+
+            int maxFrame = 64;
+            while (vfxComponent.culled && --maxFrame > 0)
+                yield return null;
+            Assert.IsTrue(maxFrame > 0);
+
+            while (--maxFrame > 0 && VFXCustomSpawnerTimeCheckerTest.s_ReadInternalTotalTime < 0.2f)
+                yield return null;
+            Assert.IsTrue(maxFrame > 0);
+
+            //Moved the object until culled
+            var backupPosition = vfxComponent.transform.position;
+
+            maxFrame = 64;
+            while (--maxFrame > 0 && !vfxComponent.culled)
+            {
+                vfxComponent.transform.position = vfxComponent.transform.position + Vector3.up * 5.0f;
+                yield return null;
+            }
+            Assert.IsTrue(maxFrame > 0);
+
+            for (int i = 0; i < 8; ++i)
+                yield return null;
+
+            vfxComponent.transform.position = backupPosition;
+
+            for (int i = 0; i < 8; ++i)
+                yield return null;
+
+            Assert.AreEqual((double)VFXCustomSpawnerTimeCheckerTest.s_ReadInternalTotalTime, (double)VFXCustomSpawnerTimeCheckerTest.s_ReadTotalTimeThroughInput, 0.0001f);
+            yield return new ExitPlayMode();
+        }
+
 #pragma warning disable 0414
         public static object[] updateModes = { VFXUpdateMode.FixedDeltaTime, VFXUpdateMode.DeltaTime };
 #pragma warning restore 0414