HDRP - Fix Debug View Material (#182)

PaulDemeulenaere · GitHub Enterprise · commit 755227a44250 · 2021-01-18T10:49:29.000+01:00
* Fix fallback (?) depth state in debug view material

Not sure about this : should double check with HDRP team

* *Update changelog

* *Updare reference image

It corresponds to the result in 7.x.x &amp; 8.x.x
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugAlbedo.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugAlbedo.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:a0e154a51e6ac0e7759ea3618178ae98ef6a01801890578d0a32089177070e99
-size 3753
+oid sha256:738e22dbea4e2351efeb47b04a5a86eaa2155a62bd93bdb7658bca5dac7351cf
+size 3861
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugAlpha.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugAlpha.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:63c689a78eb8558197d60ad0ee62bc41c813009b8b971bf592120333d727228c
-size 2416
+oid sha256:313faa25fe41edd56e15ffa141a03114da9c5ac048d996ffbe4a2995a29ec175
+size 2421
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugMetal.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugMetal.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9bfc416375a65c59c023656d58183f945b26ad99f4017615de40f4359cfba0a3
-size 965
+oid sha256:197976d7c7d3924a1ea0d59e4c96bbe6e8998c6beadb7b874ed4c6363ccfcd1c
+size 1278
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugNormal.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugNormal.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:a5edaab66ed9a83a802cb6263e3064515ebd7289d0bcb1232da38b2df5268581
-size 20749
+oid sha256:6a570e61db8142765cd6da525cdc9672f850312d36c3b875b8b51c01719158ea
+size 20995
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugSmoothness.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/HDRP_DebugSmoothness.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:d45d457ddfa6186781767dbc3a1271da11aff69d5e25fe86fc1d4a6e01eab384
-size 1933
+oid sha256:6ca328c297e32cb8f453f3ce1611729b581ad83bd46f898ae428d265126a3a90
+size 2210
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugAlbedo.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugAlbedo.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:a0e154a51e6ac0e7759ea3618178ae98ef6a01801890578d0a32089177070e99
-size 3753
+oid sha256:738e22dbea4e2351efeb47b04a5a86eaa2155a62bd93bdb7658bca5dac7351cf
+size 3861
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugAlpha.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugAlpha.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:63c689a78eb8558197d60ad0ee62bc41c813009b8b971bf592120333d727228c
-size 2416
+oid sha256:313faa25fe41edd56e15ffa141a03114da9c5ac048d996ffbe4a2995a29ec175
+size 2421
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugMetal.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugMetal.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9bfc416375a65c59c023656d58183f945b26ad99f4017615de40f4359cfba0a3
-size 965
+oid sha256:197976d7c7d3924a1ea0d59e4c96bbe6e8998c6beadb7b874ed4c6363ccfcd1c
+size 1278
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugNormal.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugNormal.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:a5edaab66ed9a83a802cb6263e3064515ebd7289d0bcb1232da38b2df5268581
-size 20749
+oid sha256:6a570e61db8142765cd6da525cdc9672f850312d36c3b875b8b51c01719158ea
+size 20995
diff --git a/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugSmoothness.png b/TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/HDRP_DebugSmoothness.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:d45d457ddfa6186781767dbc3a1271da11aff69d5e25fe86fc1d4a6e01eab384
-size 1933
+oid sha256:6ca328c297e32cb8f453f3ce1611729b581ad83bd46f898ae428d265126a3a90
+size 2210
diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md
@@ -36,6 +36,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed timing issues with accumulation motion blur
 - Fixed an issue with the frame count management for the volumetric fog (case 1299251).
 - Fixed an issue with material using distortion from ShaderGraph init after Material creation (case 1294026)
+- VFX : Debug material view incorrect depth test. (case 1293291)
 
 ### Changed
 - Removed the material pass probe volumes evaluation mode.
diff --git a/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.Debug.cs b/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.Debug.cs
@@ -528,7 +528,7 @@ TextureHandle RenderDebugViewMaterial(RenderGraph renderGraph, CullingResults cu
                     passData.transparentRendererList = builder.UseRendererList(
                         renderGraph.CreateRendererList(CreateTransparentRendererListDesc(cull, hdCamera.camera, m_AllTransparentPassNames,
                             rendererConfiguration: m_CurrentRendererConfigurationBakedLighting,
-                            stateBlock: m_DepthStateOpaque)));
+                            stateBlock: m_DepthStateNoWrite)));
 
                     passData.clearColorTexture = Compositor.CompositionManager.GetClearTextureForStackedCamera(hdCamera);   // returns null if is not a stacked camera
                     passData.clearDepthTexture = Compositor.CompositionManager.GetClearDepthForStackedCamera(hdCamera);     // returns null if is not a stacked camera
