Fix compute culling compilation in URP (case 1309174) (#210)

gabrieldelacruz · julienf-unity · commit 69cedd05f75e · 2021-02-24T13:42:53.000+01:00
* Add GeometricTools.hlsl include

Missing include containing DistanceFromPlane function used by IsSphereOutsideFrustum

* Update changelog
diff --git a/com.unity.visualeffectgraph/CHANGELOG.md b/com.unity.visualeffectgraph/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Modified Sign operator node output for float when input is 0.0f [Case 1299922](https://fogbugz.unity3d.com/f/cases/1299922/)
 - Use alphabetical order in type list in blackboard "+" button [Case 1304109](https://issuetracker.unity3d.com/product/unity/issues/guid/1304109/)
 - Consistently displays the Age Particles checkbox in Update context [Case 1221557](https://issuetracker.unity3d.com/product/unity/issues/guid/1221557/)
+- Fix compute culling compilation in URP [Case 1309174](https://fogbugz.unity3d.com/f/cases/1309174/)
 
 ## [10.3.1] - 2020-01-26
 
diff --git a/com.unity.visualeffectgraph/Shaders/VFXOutputUpdate.template b/com.unity.visualeffectgraph/Shaders/VFXOutputUpdate.template
@@ -45,6 +45,9 @@ CBUFFER_END
 
 ${VFXGeneratedBlockFunction}
 
+#if VFX_FEATURE_FRUSTUM_CULL || VFX_FEATURE_LOD
+#include "Packages/com.unity.render-pipelines.core/ShaderLibrary/GeometricTools.hlsl"
+
 bool IsSphereOutsideFrustum(float3 pos, float radius, float4 frustumPlanes[6])
 {
     bool outside = false;
@@ -53,6 +56,7 @@ bool IsSphereOutsideFrustum(float3 pos, float radius, float4 frustumPlanes[6])
         outside = outside || DistanceFromPlane(pos, frustumPlanes[i]) < -radius;
     return outside;
 }
+#endif
 
 [numthreads(NB_THREADS_PER_GROUP,1,1)]
 void CSMain(uint3 groupId		: SV_GroupID,

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,9 @@ CBUFFER_END`
`45`	`45`
`46`	`46`	`${VFXGeneratedBlockFunction}`
`47`	`47`
	`48`	`+#if VFX_FEATURE_FRUSTUM_CULL \|\| VFX_FEATURE_LOD`
	`49`	`+#include "Packages/com.unity.render-pipelines.core/ShaderLibrary/GeometricTools.hlsl"`
	`50`	`+`
`48`	`51`	`bool IsSphereOutsideFrustum(float3 pos, float radius, float4 frustumPlanes[6])`
`49`	`52`	`{`
`50`	`53`	`bool outside = false;`
`@@ -53,6 +56,7 @@ bool IsSphereOutsideFrustum(float3 pos, float radius, float4 frustumPlanes[6])`
`53`	`56`	`outside = outside \|\| DistanceFromPlane(pos, frustumPlanes[i]) < -radius;`
`54`	`57`	`return outside;`
`55`	`58`	`}`
	`59`	`+#endif`
`56`	`60`
`57`	`61`	`[numthreads(NB_THREADS_PER_GROUP,1,1)]`
`58`	`62`	`void CSMain(uint3 groupId : SV_GroupID,`