Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

Author: julienf-unity

TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXDataTests.cs

@@ -161,6 +161,34 @@ public void CheckAttributes()
             Assert.IsFalse(data.IsCurrentAttributeWritten(attrib3));
             Assert.IsTrue(data.IsCurrentAttributeWritten(attrib4));
         }
+
+        [Test]
+        public void CheckCapacityCannotBeZero()
+        {
+            var init = ScriptableObject.CreateInstance<ContextTestInit>();
+            var data = init.GetData();
+            data.SetSettingValue("capacity", 0u);
+            uint capacity = (uint)data.GetSettingValue("capacity");
+            Assert.NotZero(capacity);
+        }
+
+        [Test]
+        public void CheckStripCapacityCannotBeZero()
+        {
+            var init = ScriptableObject.CreateInstance<ContextTestInit>();
+            var data = init.GetData();
+            data.SetSettingValue("dataType", VFXDataParticle.DataType.ParticleStrip);
+            data.SetSettingValue("stripCapacity", 0u);
+            data.SetSettingValue("particlePerStripCount", 0u);
+
+            uint capacity = (uint)data.GetSettingValue("capacity");
+            uint stripCapacity = (uint)data.GetSettingValue("stripCapacity");
+            uint particlePerStripCount = (uint)data.GetSettingValue("particlePerStripCount");
+
+            Assert.NotZero(capacity);
+            Assert.NotZero(stripCapacity);
+            Assert.NotZero(particlePerStripCount);
+        }
     }
 }
 #endif

com.unity.visualeffectgraph/CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Fixed
+- Prevent capacity from being 0 [Case 1233044](https://issuetracker.unity3d.com/product/unity/issues/guid/1233044/)
+
 ## [9.0.0] - 2020-07-09
 
 ### Added

com.unity.visualeffectgraph/Editor/Data/VFXDataParticle.cs

@@ -195,7 +195,7 @@ class VFXDataParticle : VFXData, ISpaceable
     {
         public override VFXDataType type { get { return hasStrip ? VFXDataType.ParticleStrip : VFXDataType.Particle; } }
 
-        protected enum DataType
+        internal enum DataType
         {
             Particle,
             ParticleStrip
@@ -215,6 +215,14 @@ protected enum DataType
         protected override void OnSettingModified(VFXSetting setting)
         {
             base.OnSettingModified(setting);
+
+            if (setting.name == "capacity" && capacity == 0)
+                capacity = 1;
+            else if (setting.name == "stripCapacity" && stripCapacity == 0)
+                stripCapacity = 1;
+            else if (setting.name == "particlePerStripCount" && particlePerStripCount == 0)
+                particlePerStripCount = 1;
+
             if (hasStrip)
             {
                 if (setting.name == "dataType") // strip has just been set