Fix state packing and shouldRenderCachedComponent setting (#110)

Author: AdamStrickUnity

com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDGpuLightsBuilder.LightLoop.cs

@@ -683,7 +683,7 @@ internal unsafe void CalculateShadowIndices(
                         ref HDAdditionalLightDataUpdateInfo updateInfo = ref UnsafeUtility.AsRef<HDAdditionalLightDataUpdateInfo>(updateInfosUnsafePtr + additionalLightDataIndex);
 
                         shadowRequest.shouldUseCachedShadowData = false;
-
+                        shadowRequest.shouldRenderCachedComponent = false;
                         shadowRequest.cachedShadowData.cacheTranslationDelta = new Vector3(0.0f, 0.0f, 0.0f);
 
                         // Write per light type matrices, splitDatas and culling parameters

com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDLightRenderDatabase.cs

@@ -102,7 +102,7 @@ public void SetTypeData(byte typeIndex, byte value)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public byte GetTypeData(byte typeIndex)
         {
-            return (byte)(typeData & (0b11 << (typeIndex * 2)));
+            return (byte)((typeData >> (typeIndex * 2)) & 0b11);
         }
 
         public SpotLightShape spotLightShape
@@ -125,8 +125,8 @@ public ShadowUpdateMode shadowUpdateMode
 
         public HDAdditionalLightData.PointLightHDType pointLightHDType
         {
-            get => (HDAdditionalLightData.PointLightHDType)((typeData >> 6) & 0b11);
-            set => typeData = (byte)((typeData & 0b00111111) | (((int)value) << 6));
+            [MethodImpl(MethodImplOptions.AggressiveInlining)] get => (HDAdditionalLightData.PointLightHDType)GetTypeData(3);
+            [MethodImpl(MethodImplOptions.AggressiveInlining)] set => SetTypeData(3, (byte)value);
         }
 
         public bool useCustomSpotLightShadowCone

com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/UpdateShadowRequestsAndCalculateIndicesJob.cs

@@ -602,7 +602,7 @@ public void UpdateDynamicPointShadowRequestsAndResolutionRequests()
                 HDAdditionalLightDataUpdateInfo updateInfo = additionalLightDataUpdateInfos[additionalLightDataIndex];
 
                 shadowRequest.shouldUseCachedShadowData = false;
-
+                shadowRequest.shouldRenderCachedComponent = false;
                 shadowRequest.cachedShadowData.cacheTranslationDelta = new Vector3(0.0f, 0.0f, 0.0f);
 
                 // Write per light type matrices, splitDatas and culling parameters
@@ -712,7 +712,7 @@ public void UpdateDynamicSpotShadowRequestsAndResolutionRequests()
                 HDAdditionalLightDataUpdateInfo updateInfo = additionalLightDataUpdateInfos[additionalLightDataIndex];
 
                 shadowRequest.shouldUseCachedShadowData = false;
-
+                shadowRequest.shouldRenderCachedComponent = false;
                 shadowRequest.cachedShadowData.cacheTranslationDelta = new Vector3(0.0f, 0.0f, 0.0f);
 
                 // Write per light type matrices, splitDatas and culling parameters
@@ -849,7 +849,7 @@ public void UpdateDynamicAreaShadowRequestsAndResolutionRequests(NativeList<Shad
                 HDAdditionalLightDataUpdateInfo updateInfo = additionalLightDataUpdateInfos[additionalLightDataIndex];
 
                 shadowRequest.shouldUseCachedShadowData = false;
-
+                shadowRequest.shouldRenderCachedComponent = false;
                 shadowRequest.cachedShadowData.cacheTranslationDelta = new Vector3(0.0f, 0.0f, 0.0f);
 
                 /// Write per light type matrices, splitDatas and culling parameters

com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDCachedShadowAtlas.cs

@@ -82,6 +82,7 @@ public HDCachedShadowAtlas(ShadowMapType type)
             m_RecordsPendingPlacement = new NativeHashMap<int, CachedShadowRecord>(s_InitialCapacity, Allocator.Persistent);
 
             m_TransformCaches = new NativeHashMap<int, CachedTransform>(s_InitialCapacity / 2, Allocator.Persistent);
+            m_IsACacheForShadows = true;
         }
 
         public override void InitAtlas(HDShadowAtlasInitParameters atlasInitParams)

com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowAtlas.cs

@@ -178,21 +178,6 @@ public void UpdateSize(Vector2Int size)
             }
         }
 
-        internal void AddShadowRequest(HDShadowRequestHandle shadowRequest)
-        {
-            m_ShadowRequests.Add(shadowRequest);
-        }
-
-        internal static void AddShadowRequest(ref HDDynamicShadowAtlasUnmanaged shadowAtlas, HDShadowRequestHandle shadowRequest)
-        {
-            shadowAtlas.shadowRequests.Add(shadowRequest);
-        }
-
-        internal static void AddShadowRequest(ref HDCachedShadowAtlasUnmanaged shadowAtlas, HDShadowRequestHandle shadowRequest)
-        {
-            shadowAtlas.shadowRequests.Add(shadowRequest);
-        }
-
         public void UpdateDebugSettings(LightingDebugSettings lightingDebugSettings)
         {
             m_LightingDebugSettings = lightingDebugSettings;