Skip to content

Commit 52fc481

Browse files
[HDRP] Fix runtime debug UI showing wrong entry (#2595)
* Redraw debug before re-registring the debugs * changelog
1 parent c7cd799 commit 52fc481

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

com.unity.render-pipelines.high-definition/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
1111

1212
### Fixed
1313
- Fixed probe volumes debug views.
14+
- Fixed issue displaying wrong debug mode in runtime debug menu UI.
1415

1516
## [10.2.0] - 2020-10-19
1617

com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1008,56 +1008,62 @@ void RegisterMaterialDebug()
10081008
void RefreshDisplayStatsDebug<T>(DebugUI.Field<T> field, T value)
10091009
{
10101010
UnregisterDebugItems(k_PanelDisplayStats, m_DebugDisplayStatsItems);
1011-
RegisterDisplayStatsDebug();
10121011

10131012
if (DebugManager.instance.displayRuntimeUI)
10141013
DebugManager.instance.ReDrawOnScreenDebug();
1014+
1015+
RegisterDisplayStatsDebug();
10151016
}
10161017

10171018
// For now we just rebuild the lighting panel if needed, but ultimately it could be done in a better way
10181019
void RefreshLightingDebug<T>(DebugUI.Field<T> field, T value)
10191020
{
10201021
UnregisterDebugItems(k_PanelLighting, m_DebugLightingItems);
1021-
RegisterLightingDebug();
10221022

10231023
if (DebugManager.instance.displayRuntimeUI)
10241024
DebugManager.instance.ReDrawOnScreenDebug();
1025+
1026+
RegisterLightingDebug();
10251027
}
10261028

10271029
void RefreshDecalsDebug<T>(DebugUI.Field<T> field, T value)
10281030
{
10291031
UnregisterDebugItems(k_PanelDecals, m_DebugDecalsAffectingTransparentItems);
1030-
RegisterDecalsDebug();
10311032

10321033
if (DebugManager.instance.displayRuntimeUI)
10331034
DebugManager.instance.ReDrawOnScreenDebug();
1035+
1036+
RegisterDecalsDebug();
10341037
}
10351038

10361039
void RefreshRenderingDebug<T>(DebugUI.Field<T> field, T value)
10371040
{
10381041
UnregisterDebugItems(k_PanelRendering, m_DebugRenderingItems);
1039-
RegisterRenderingDebug();
10401042

10411043
if (DebugManager.instance.displayRuntimeUI)
10421044
DebugManager.instance.ReDrawOnScreenDebug();
1045+
1046+
RegisterRenderingDebug();
10431047
}
10441048

10451049
void RefreshMaterialDebug<T>(DebugUI.Field<T> field, T value)
10461050
{
10471051
UnregisterDebugItems(k_PanelMaterials, m_DebugMaterialItems);
1048-
RegisterMaterialDebug();
10491052

10501053
if (DebugManager.instance.displayRuntimeUI)
10511054
DebugManager.instance.ReDrawOnScreenDebug();
1055+
1056+
RegisterMaterialDebug();
10521057
}
10531058

10541059
void RefreshVolumeDebug<T>(DebugUI.Field<T> field, T value)
10551060
{
10561061
UnregisterDebugItems(k_PanelVolume, m_DebugVolumeItems);
1057-
RegisterVolumeDebug();
10581062

10591063
if (DebugManager.instance.displayRuntimeUI)
10601064
DebugManager.instance.ReDrawOnScreenDebug();
1065+
1066+
RegisterVolumeDebug();
10611067
}
10621068

10631069
void RegisterLightingDebug()

0 commit comments

Comments
 (0)