Fix issue causing not all baked reflection probes to be deleted #441

Author: FrancescoC-unity

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -79,6 +79,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed cookie texture not updated when changing an import settings (srgb for example).
 - Fix error when removing DecalProjector from component contextual menu (case 1243960)
 - Fixed issue with post process when running in RGBA16 and an object with additive blending is in the scene.
+- Fixed issue that caused not all baked reflection to be deleted upon clicking "Clear Baked Data" in the lighting menu (case 1136080)
 
 ### Changed
 - Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history.

com.unity.render-pipelines.high-definition/Editor/Lighting/Reflection/HDBakedReflectionSystem.cs

@@ -471,8 +471,13 @@ void DeleteCubemapAssets(bool deleteUnusedOnly)
                             // Or we delete all assets
                             || !deleteUnusedOnly)
                         {
+                            // If the buffer is full we empty it and then push again the element we were trying to
+                            // push but failed.
                             if (!buffer.TryPush(files[fileI]))
+                            {
                                 DeleteAllAssetsIn(ref buffer);
+                                buffer.TryPush(files[fileI]);
+                            }
                         }
                     }
                 }
@@ -489,6 +494,9 @@ static void DeleteAllAssetsIn(ref CoreUnsafeUtils.FixedBufferStringQueue queue)
             while (queue.TryPop(out string path))
                 AssetDatabase.DeleteAsset(path);
             AssetDatabase.StopAssetEditing();
+
+            // Clear the queue so that can be filled again.
+            queue.Clear();
         }
 
         internal static void Checkout(string targetFile)